src/PNaClTranslator.cpp - Issue 1674033002: Subzero: Clean up some uses of *_cast<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/PNaClTranslator.cpp

Issue 1674033002: Subzero: Clean up some uses of *_cast<>. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Cleanup of llvm::cast<> style operations Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/PNaClTranslator.cpp

diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp

index ed2a90785c51d5a6a673b2f91c9f837639053bf9..2d4181211b935948403a625cbed022dad6771647 100644

--- a/src/PNaClTranslator.cpp

+++ b/src/PNaClTranslator.cpp

@@ -2737,7 +2737,7 @@ void FunctionParser::ProcessRecord() {

appendErrorInstruction(ReturnType);

return;

}

- bool IsTailCall = static_cast<bool>(CCInfo & 1);

+ auto IsTailCall = static_cast<bool>(CCInfo & 1);

John 2016/02/07 16:18:33 bool IsTailCall = ...; While at this, const?

Jim Stichnoth 2016/02/07 17:44:41 Done.

// Create the call instruction.

Ice::Variable *Dest = (ReturnType == Ice::IceType_void)

« src/IceTargetLoweringX86BaseImpl.h ('K') | « src/IceTypes.cpp ('k') | no next file » | no next file with comments »