Subzero: Clean up some uses of *_cast<>.

src/PNaClTranslator.cpp

 //===- subzero/src/PNaClTranslator.cpp - ICE from bitcode -----------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 2719 matching lines @@
     CallingConv::ID CallingConv;
     if (!naclbitc::DecodeCallingConv(CCInfo >> 1, CallingConv)) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Function call calling convention value " << (CCInfo >> 1)
              << " not understood.";
       Error(StrBuf.str());
       appendErrorInstruction(ReturnType);
       return;
     }
-    bool IsTailCall = static_cast<bool>(CCInfo & 1);
+    auto IsTailCall = static_cast<bool>(CCInfo & 1);

[John, 2016/02/07 16:18:33]

bool IsTailCall = ...;

While at this, const?

[Jim Stichnoth, 2016/02/07 17:44:41]

Done.

 
     // Create the call instruction.
     Ice::Variable *Dest = (ReturnType == Ice::IceType_void)
                               ? nullptr
                               : getNextInstVar(ReturnType);
     std::unique_ptr<Ice::InstCall> Instr;
     if (IntrinsicInfo) {
       Instr.reset(Ice::InstIntrinsicCall::create(
           Func.get(), Params.size(), Dest, Callee, IntrinsicInfo->Info));
     } else {
@@ skipping 452 matching lines @@
     raw_string_ostream StrBuf(Buffer);
     StrBuf << IRFilename << ": Does not contain a module!";
     llvm::report_fatal_error(StrBuf.str());
   }
   if (InputStreamFile.getBitcodeBytes().getExtent() % 4 != 0) {
     llvm::report_fatal_error("Bitcode stream should be a multiple of 4 bytes");
   }
 }
 
 } // end of namespace Ice