Subzero: Clean up some uses of *_cast<>.

src/IceTargetLoweringX8632Traits.h

Index: src/IceTargetLoweringX8632Traits.h
diff --git a/src/IceTargetLoweringX8632Traits.h b/src/IceTargetLoweringX8632Traits.h
index 897aa3b767119af410b5b0ad0d50d6b4b1236ce6..238230a0bacdfba056f8e693e599881860910e96 100644
--- a/src/IceTargetLoweringX8632Traits.h
+++ b/src/IceTargetLoweringX8632Traits.h
@@ -733,9 +733,7 @@ public:
   /// representation of the vector.
   static Type getInVectorElementType(Type Ty) {
     assert(isVectorType(Ty));
-    size_t Index = static_cast<size_t>(Ty);
-    (void)Index;
-    assert(Index < TableTypeX8632AttributesSize);
+    assert(Ty < TableTypeX8632AttributesSize);
     return TableTypeX8632Attributes[Ty].InVectorElementType;
   }
 
@@ -790,9 +788,8 @@ public:
   /// @}
 
   static Cond::BrCond getIcmp32Mapping(InstIcmp::ICond Cond) {
-    size_t Index = static_cast<size_t>(Cond);
-    assert(Index < TableIcmp32Size);
-    return TableIcmp32[Index].Mapping;
+    assert(Cond < TableIcmp32Size);
+    return TableIcmp32[Cond].Mapping;
   }
 
   static const struct TableTypeX8632AttributesType {
@@ -959,7 +956,7 @@ public:
     static SpillVariable *create(Cfg *Func, Type Ty, SizeT Index) {
       return new (Func->allocate<SpillVariable>()) SpillVariable(Ty, Index);
     }
-    const static OperandKind SpillVariableKind =
+    const static auto SpillVariableKind =

[John, 2016/02/07 16:18:33]

While at this, constexpr?

[Jim Stichnoth, 2016/02/07 16:42:42]

Done.

         static_cast<OperandKind>(kVariable_Target);
     static bool classof(const Operand *Operand) {
       return Operand->getKind() == SpillVariableKind;