src/IceTargetLoweringMIPS32.cpp - Issue 1674033002: Subzero: Clean up some uses of *_cast<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringMIPS32.cpp

Issue 1674033002: Subzero: Clean up some uses of *_cast<>. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Cleanup of llvm::cast<> style operations Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringMIPS32.cpp

diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp

index ff93c4b78ae6bfcf13cc13cf33ccb80946b7571e..6b1a1d368b92eb3719bdd77dba6f09a2c3352972 100644

--- a/src/IceTargetLoweringMIPS32.cpp

+++ b/src/IceTargetLoweringMIPS32.cpp

@@ -1245,7 +1245,7 @@ Operand *TargetMIPS32::legalize(Operand *From, LegalMask Allowed,

Context.insert<InstFakeDef>(Reg);

return Reg;

} else if (auto *C32 = llvm::dyn_cast<ConstantInteger32>(From)) {

- uint32_t Value = static_cast<uint32_t>(C32->getValue());

+ auto Value = static_cast<uint32_t>(C32->getValue());

John 2016/02/07 16:18:33 uint32_t Value = ...; While at this, const?

Jim Stichnoth 2016/02/07 17:44:41 Done.

// Check if the immediate will fit in a Flexible second operand,

// if a Flexible second operand is allowed. We need to know the exact

// value, so that rules out relocatable constants.

« src/IceInstARM32.h ('K') | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringX8632Traits.h » ('j') | src/IceTargetLoweringX8632Traits.h » ('J')