Subzero: Clean up some uses of *_cast<>.

src/IceAssemblerARM32.cpp

Index: src/IceAssemblerARM32.cpp
diff --git a/src/IceAssemblerARM32.cpp b/src/IceAssemblerARM32.cpp
index 8291f51e939f1e708332e1e3d807db38c6422b4a..800d9baa7d129622610b3697c9482c3db861a59a 100644
--- a/src/IceAssemblerARM32.cpp
+++ b/src/IceAssemblerARM32.cpp
@@ -706,7 +706,7 @@ Label *AssemblerARM32::getOrCreateLabel(SizeT Number, LabelVector &Labels) {
 // Pull out offset from branch Inst.
 IOffsetT AssemblerARM32::decodeBranchOffset(IValueT Inst) {
   // Sign-extend, left-shift by 2, and adjust to the way ARM CPUs read PC.
-  IOffsetT Offset = static_cast<IOffsetT>((Inst & kBranchOffsetMask) << 8);
+  auto Offset = static_cast<IOffsetT>((Inst & kBranchOffsetMask) << 8);

[John, 2016/02/07 16:18:32]

I'd prefer

IOffsetT Offset = ...;

[Jim Stichnoth, 2016/02/07 16:42:42]

You mean the original way?  I'm curious why, since this seems to be a poster
child for use of "auto".

[John, 2016/02/07 16:59:43]

I meant

const IOffsetT Offset = (Inst & kBranchOffsetMask) << 8;

In other words, I'd let the declaration cast the rhs. Not sure if this works,
though.

[Jim Stichnoth, 2016/02/07 17:44:41]

Done.

   return (Offset >> 6) + kPCReadOffset;
 }