Subzero: Clean up some uses of *_cast<>.

src/IceAssemblerARM32.cpp

 //===- subzero/src/IceAssemblerARM32.cpp - Assembler for ARM32 --*- C++ -*-===//
 //
 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Modified by the Subzero authors.
 //
 //===----------------------------------------------------------------------===//
 //
@@ skipping 688 matching lines @@
   if (!L) {
     L = new (this->allocate<Label>()) Label();
     Labels[Number] = L;
   }
   return L;
 }
 
 // Pull out offset from branch Inst.
 IOffsetT AssemblerARM32::decodeBranchOffset(IValueT Inst) {
   // Sign-extend, left-shift by 2, and adjust to the way ARM CPUs read PC.
-  IOffsetT Offset = static_cast<IOffsetT>((Inst & kBranchOffsetMask) << 8);
+  auto Offset = static_cast<IOffsetT>((Inst & kBranchOffsetMask) << 8);

[John, 2016/02/07 16:18:32]

I'd prefer

IOffsetT Offset = ...;

[Jim Stichnoth, 2016/02/07 16:42:42]

You mean the original way?  I'm curious why, since this seems to be a poster
child for use of "auto".

[John, 2016/02/07 16:59:43]

I meant

const IOffsetT Offset = (Inst & kBranchOffsetMask) << 8;

In other words, I'd let the declaration cast the rhs. Not sure if this works,
though.

[Jim Stichnoth, 2016/02/07 17:44:41]

Done.

   return (Offset >> 6) + kPCReadOffset;
 }
 
 void AssemblerARM32::bind(Label *L) {
   IOffsetT BoundPc = Buffer.size();
   assert(!L->isBound()); // Labels can only be bound once.
   while (L->isLinked()) {
     IOffsetT Position = L->getLinkPosition();
     IOffsetT Dest = BoundPc - Position;
     IValueT Inst = Buffer.load<IValueT>(Position);
@@ skipping 2331 matching lines @@
   constexpr const char *Vsqrts = "vsqrts";
   IValueT Sd = encodeSRegister(OpSd, "Sd", Vsqrts);
   IValueT Sm = encodeSRegister(OpSm, "Sm", Vsqrts);
   constexpr IValueT VsqrtsOpcode = B23 | B21 | B20 | B16 | B7 | B6;
   constexpr IValueT S0 = 0;
   emitVFPsss(Cond, VsqrtsOpcode, Sd, S0, Sm);
 }
 
 } // end of namespace ARM32
 } // end of namespace Ice