Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: src/IceAssemblerARM32.cpp

Issue 1674033002: Subzero: Clean up some uses of *_cast<>. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Cleanup of llvm::cast<> style operations Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/IceCfg.cpp » ('j') | src/IceInstARM32.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceAssemblerARM32.cpp
diff --git a/src/IceAssemblerARM32.cpp b/src/IceAssemblerARM32.cpp
index 8291f51e939f1e708332e1e3d807db38c6422b4a..800d9baa7d129622610b3697c9482c3db861a59a 100644
--- a/src/IceAssemblerARM32.cpp
+++ b/src/IceAssemblerARM32.cpp
@@ -706,7 +706,7 @@ Label *AssemblerARM32::getOrCreateLabel(SizeT Number, LabelVector &Labels) {
// Pull out offset from branch Inst.
IOffsetT AssemblerARM32::decodeBranchOffset(IValueT Inst) {
// Sign-extend, left-shift by 2, and adjust to the way ARM CPUs read PC.
- IOffsetT Offset = static_cast<IOffsetT>((Inst & kBranchOffsetMask) << 8);
+ auto Offset = static_cast<IOffsetT>((Inst & kBranchOffsetMask) << 8);
John 2016/02/07 16:18:32 I'd prefer IOffsetT Offset = ...;
Jim Stichnoth 2016/02/07 16:42:42 You mean the original way? I'm curious why, since
John 2016/02/07 16:59:43 I meant const IOffsetT Offset = (Inst & kBranchOf
Jim Stichnoth 2016/02/07 17:44:41 Done.
return (Offset >> 6) + kPCReadOffset;
}
« no previous file with comments | « no previous file | src/IceCfg.cpp » ('j') | src/IceInstARM32.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698