Child thread attachment broker should never be destroyed.

Child thread attachment broker should never be destroyed.

The attachment broker needs to last as long as the longest lived IPC::Channel.
There's no harm in leaking the object, so just prevent it from ever being
destroyed.

BUG=584297

[erikchen, 2016-02-05 21:36:11]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 21:37:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673803002/1

[commit-bot: I haz the power, 2016-02-05 23:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 23:06:30]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-02-06 01:00:42]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-02-06 01:00:42]

avi: Please review.

[Avi (use Gerrit), 2016-02-06 07:03:40]

https://codereview.chromium.org/1673803002/diff/1/content/child/child_thread_...
File content/child/child_thread_impl.cc (right):

https://codereview.chromium.org/1673803002/diff/1/content/child/child_thread_...
content/child/child_thread_impl.cc:374: // Intentionally leak the attachment
broker so that it is never destroyed.
Mention _why_ you leak it, not just that you do.

[erikchen, 2016-02-09 02:39:14]

On 2016/02/06 07:03:40, Avi wrote:
>
https://codereview.chromium.org/1673803002/diff/1/content/child/child_thread_...
> File content/child/child_thread_impl.cc (right):
> 
>
https://codereview.chromium.org/1673803002/diff/1/content/child/child_thread_...
> content/child/child_thread_impl.cc:374: // Intentionally leak the attachment
> broker so that it is never destroyed.
> Mention _why_ you leak it, not just that you do.

closing this CL. cleaner CL on it's way:
https://codereview.chromium.org/1679763002/

[erikchen, 2016-02-09 02:39:18]

Description was changed from

==========
Child thread attachment broker should never be destroyed.

The attachment broker needs to last as long as the longest lived IPC::Channel.
There's no harm in leaking the object, so just prevent it from ever being
destroyed.

BUG=584297
==========

to

==========
Child thread attachment broker should never be destroyed.

The attachment broker needs to last as long as the longest lived IPC::Channel.
There's no harm in leaking the object, so just prevent it from ever being
destroyed.

BUG=584297
==========