Make it possible to switch between two different versions of ANGLE.

Make it possible to switch between two different versions of ANGLE.

One is the existing one and the default with this patch: third_party/angle.
The other is third_party/angle_dx11, which will pulled in via DEPS in another patch.

BUG=247158
TBR=xhwang@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205962

[apatrick_chromium, 2013-06-11 23:29:49]

See also https://codereview.chromium.org/16776009/ and
https://codereview.chromium.org/16123033/#ps24002, the latter being a sanity
check that we can pull from the git repository.

[Ken Russell (switch to Gerrit), 2013-06-11 23:47:03]

LGTM if it compiles.

https://codereview.chromium.org/16737007/diff/12001/content/DEPS
File content/DEPS (right):

https://codereview.chromium.org/16737007/diff/12001/content/DEPS#newcode55
content/DEPS:55: "+third_party/angle_dx11",
It occurs to me you'll need to duplicate the ANGLE entry in
src/tools/checklicenses/checklicenses.py as well.

[apatrick_chromium, 2013-06-12 00:12:12]

On 2013/06/11 23:47:03, kbr wrote:
> LGTM if it compiles.
> 
> https://codereview.chromium.org/16737007/diff/12001/content/DEPS
> File content/DEPS (right):
> 
> https://codereview.chromium.org/16737007/diff/12001/content/DEPS#newcode55
> content/DEPS:55: "+third_party/angle_dx11",
> It occurs to me you'll need to duplicate the ANGLE entry in
> src/tools/checklicenses/checklicenses.py as well.

We're going to add an appropriate README.chromium to the new ANGLE git
repository.

[apatrick_chromium, 2013-06-12 20:52:59]

+piman for content/content_tests.gypi owners
+xhwang for media/ owners

[piman, 2013-06-12 20:55:25]

LGTM with me but make sure the opensource / third_party folks are ok with having
2 versions of ANGLE concurrently in the tree.

[piman, 2013-06-12 20:56:43]

On Wed, Jun 12, 2013 at 1:55 PM, <piman@chromium.org> wrote:

> LGTM with me but make sure the opensource / third_party folks are ok with
> having
> 2 versions of ANGLE concurrently in the tree.
>

Also, we include angle headers in many places in the tree. Will it be ok to
include the DX9 headers but link with the DX11 version?


>
>
https://codereview.chromium.**org/16737007/<https://codereview.chromium.org/1...
>

[apatrick_chromium, 2013-06-12 20:57:48]

On 2013/06/12 20:55:25, piman wrote:
> LGTM with me but make sure the opensource / third_party folks are ok with
having
> 2 versions of ANGLE concurrently in the tree.

It's only going to be like that for a day or two. I'm going to delete the old
angle/ one once webkit roll complications are out of the way.

[apatrick_chromium, 2013-06-12 21:04:55]

On 2013/06/12 20:56:43, piman wrote:
> On Wed, Jun 12, 2013 at 1:55 PM, <mailto:piman@chromium.org> wrote:
> 
> > LGTM with me but make sure the opensource / third_party folks are ok with
> > having
> > 2 versions of ANGLE concurrently in the tree.
> >
> 
> Also, we include angle headers in many places in the tree. Will it be ok to
> include the DX9 headers but link with the DX11 version?
> 
> 
> >
> >
>
https://codereview.chromium.**org/16737007/%3Chttps://codereview.chromium.org...>
> >

The new "DX11" version actually supports both D3D9 and D3D11 and can switch
between them at runtime. Also, it's built as a shared library so I don't foresee
any issues. Oh and I tested it as well :)

[piman, 2013-06-12 21:07:23]

On Wed, Jun 12, 2013 at 2:04 PM, <apatrick@chromium.org> wrote:

> On 2013/06/12 20:56:43, piman wrote:
>
>  On Wed, Jun 12, 2013 at 1:55 PM, <mailto:piman@chromium.org> wrote:
>>
>
>  > LGTM with me but make sure the opensource / third_party folks are ok
>> with
>> > having
>> > 2 versions of ANGLE concurrently in the tree.
>> >
>>
>
>  Also, we include angle headers in many places in the tree. Will it be ok
>> to
>> include the DX9 headers but link with the DX11 version?
>>
>
>
>  >
>> >
>>
>
> https://codereview.chromium.****org/16737007/%3Chttps://codere**
> view.chromium.org/16737007/ <http://codereview.chromium.org/16737007/>>
>
>> >
>>
>
> The new "DX11" version actually supports both D3D9 and D3D11 and can switch
> between them at runtime. Also, it's built as a shared library so I don't
> foresee
> any issues. Oh and I tested it as well :)
>

LGTM still stands. Just wanted to bring up some things that I was thinking
of, but I trust you've been testing :)

>
>
https://codereview.chromium.**org/16737007/<https://codereview.chromium.org/1...
>

[apatrick_chromium, 2013-06-12 21:35:23]

+jamesr for webkit/ owners

[jamesr, 2013-06-12 21:47:29]

lgtm