Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1673593002: [LocalizedError] Add TODO about error suggestions on mobile (Closed)

Created:
4 years, 10 months ago by blundell
Modified:
4 years, 10 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LocalizedError] Add TODO about error suggestions on mobile It's not clear that all error suggestions should be shown on mobile, since some of them are irrelevant (e.g., disabling an extension). BUG=568415 Committed: https://crrev.com/c1f90b649ad8d6e3fc99044a407bb29e5c057914 Cr-Commit-Position: refs/heads/master@{#374657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/error_page/common/localized_error.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
blundell
4 years, 10 months ago (2016-02-05 10:07:57 UTC) #2
mmenke
LGTM. Sorry for slowness - kinda lost track of reviews at the end of last ...
4 years, 10 months ago (2016-02-09 18:30:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673593002/1
4 years, 10 months ago (2016-02-10 13:47:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 14:53:18 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c1f90b649ad8d6e3fc99044a407bb29e5c057914 Cr-Commit-Position: refs/heads/master@{#374657}
4 years, 10 months ago (2016-02-10 14:54:04 UTC) #8
dhw
Drive by review: typo in the BUG number. Should be BUG=584615 The auto-commit message in ...
4 years, 10 months ago (2016-02-10 20:19:36 UTC) #9
blundell
4 years, 10 months ago (2016-02-11 09:54:18 UTC) #10
Message was sent while issue was closed.
On 2016/02/10 20:19:36, dhw wrote:
> Drive by review:  typo in the BUG number.  Should be BUG=584615
> 
> The auto-commit message in the wrong bug should be copy-and-pasted into the
> correct bug.

Thanks! Done.

Powered by Google App Engine
This is Rietveld 408576698