components/error_page/common/localized_error.cc - Issue 1673593002: [LocalizedError] Add TODO about error suggestions on mobile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/error_page/common/localized_error.cc

Issue 1673593002: [LocalizedError] Add TODO about error suggestions on mobile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/error_page/common/localized_error.cc

diff --git a/components/error_page/common/localized_error.cc b/components/error_page/common/localized_error.cc

index a349802f46c907ef7d78f56134a34b3a1dc18dcf..88950141f68df566c2d2100788a1697cd3d82320 100644

--- a/components/error_page/common/localized_error.cc

+++ b/components/error_page/common/localized_error.cc

@@ -837,6 +837,9 @@ void LocalizedError::GetStrings(int error_code,

suggestions->Append(suggest_network_prediction);

}

+ // TODO(crbug.com/584615): Does it make sense to show all of these

+ // suggestions on mobile? Several of them seem irrelevant in the mobile

+ // context.

if (options.suggestions & SUGGEST_FIREWALL_CONFIG) {

base::DictionaryValue* suggest_firewall_config = new base::DictionaryValue;

suggest_firewall_config->SetString("header",

« no previous file with comments | « no previous file | no next file » | no next file with comments »