Fix the snapshotter to generate valid precompilation snapshots

Fix the snapshotter to generate valid precompilation snapshots

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/63e836ceae7efe82d7e29fae5a02c39e04922f62

[Chinmay, 2016-02-09 20:37:05]

chinmaygarde@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[siva, 2016-02-09 21:08:34]

https://codereview.chromium.org/1673423004/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/1673423004/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:438: return Dart_LoadScript(resolved_script_uri,
source, 0, 0);
This will break dartium, mojo, flutter for Android etc.

You should probably do
if (isSnapshottingForPrecompilation()) {
  return Dart_LoadScript(.....);
} else {
  return Dart_LoadLibrary(.....);
}

[Chinmay, 2016-02-09 21:34:03]

On 2016/02/09 at 21:08:34, asiva wrote:
> https://codereview.chromium.org/1673423004/diff/1/runtime/bin/gen_snapshot.cc
> File runtime/bin/gen_snapshot.cc (right):
> 
>
https://codereview.chromium.org/1673423004/diff/1/runtime/bin/gen_snapshot.cc...
> runtime/bin/gen_snapshot.cc:438: return Dart_LoadScript(resolved_script_uri,
source, 0, 0);
> This will break dartium, mojo, flutter for Android etc.
> 
> You should probably do
> if (isSnapshottingForPrecompilation()) {
>   return Dart_LoadScript(.....);
> } else {
>   return Dart_LoadLibrary(.....);
> }

Snapshotting for Flutter for Android does not go down this path. So I missed it.
I have applied your suggestion. Another look please.

[siva, 2016-02-09 21:44:46]

lgtm

[Chinmay, 2016-02-09 21:46:42]

Description was changed from

==========
Fix the snapshotter to generate valid precompilation snapshots
==========

to

==========
Fix the snapshotter to generate valid precompilation snapshots

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/63e836ceae7efe82d7e29fae5a02c39e04922f62
==========

[Chinmay, 2016-02-09 21:46:43]

Committed patchset #2 (id:20001) manually as
63e836ceae7efe82d7e29fae5a02c39e04922f62 (presubmit successful).