Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1750)

Side by Side Diff: runtime/BUILD.gn

Issue 1673423004: Fix the snapshotter to generate valid precompilation snapshots (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address CL feedback Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/bin/gen_snapshot.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 # TODO(zra): These build arguments should likely be moved to a gni file that is 5 # TODO(zra): These build arguments should likely be moved to a gni file that is
6 # included in BUILD.gn files that care about the values of the flags. For now, 6 # included in BUILD.gn files that care about the values of the flags. For now,
7 # since the GN build only happens as part of a Mojo build there is no need for 7 # since the GN build only happens as part of a Mojo build there is no need for
8 # the indirection. 8 # the indirection.
9 declare_args() { 9 declare_args() {
10 # Instead of using is_debug, we introduce a different flag for specifying a 10 # Instead of using is_debug, we introduce a different flag for specifying a
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 assert(false) 43 assert(false)
44 } 44 }
45 } 45 }
46 46
47 if (dart_debug) { 47 if (dart_debug) {
48 defines += ["DEBUG"] 48 defines += ["DEBUG"]
49 } else { 49 } else {
50 defines += ["NDEBUG"] 50 defines += ["NDEBUG"]
51 } 51 }
52 52
53 if (is_ios || is_mac) {
54 defines += ["DART_PRECOMPILER"]
55 }
56
53 cflags = [ 57 cflags = [
54 "-Werror", 58 "-Werror",
55 "-Wall", 59 "-Wall",
56 "-Wextra", # Also known as -W. 60 "-Wextra", # Also known as -W.
57 "-Wno-unused-parameter", 61 "-Wno-unused-parameter",
58 "-Wnon-virtual-dtor", 62 "-Wnon-virtual-dtor",
59 "-Wvla", 63 "-Wvla",
60 "-Wno-conversion-null", 64 "-Wno-conversion-null",
61 "-Woverloaded-virtual", 65 "-Woverloaded-virtual",
62 "-g3", 66 "-g3",
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 "vm:libdart_lib_nosnapshot", 148 "vm:libdart_lib_nosnapshot",
145 "vm:libdart_lib", 149 "vm:libdart_lib",
146 "vm:libdart_vm", 150 "vm:libdart_vm",
147 "vm:libdart_platform", 151 "vm:libdart_platform",
148 "third_party/double-conversion/src:libdouble_conversion", 152 "third_party/double-conversion/src:libdouble_conversion",
149 ] 153 ]
150 sources = [ 154 sources = [
151 "vm/libdart_dependency_helper.cc", 155 "vm/libdart_dependency_helper.cc",
152 ] 156 ]
153 } 157 }
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/gen_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698