Views - fix up layout of a couple dialogs

Views - fix up layout of a couple dialogs

- create application shortcuts dialog
- permissions bubble view

BUG=585254, 585014
Committed: https://crrev.com/4605d229e0791644f93df899734c5c78ba683fc0
Cr-Commit-Position: refs/heads/master@{#374756}

[Evan Stade, 2016-02-08 23:00:48]

estade@chromium.org changed reviewers:
+ msw@chromium.org, sky@chromium.org

[Evan Stade, 2016-02-08 23:00:49]

+msw for review
+sky for ui/views/layout/layout_constants.h

https://codereview.chromium.org/1673403002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1673403002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:2297: +        Add shortcuts to the following
places:
I changed this to be both more succinct and less repetitive (see screenshot on
bug)

https://codereview.chromium.org/1673403002/diff/1/chrome/browser/ui/views/cre...
File chrome/browser/ui/views/create_application_shortcut_view.cc (right):

https://codereview.chromium.org/1673403002/diff/1/chrome/browser/ui/views/cre...
chrome/browser/ui/views/create_application_shortcut_view.cc:263:
create_shortcuts_label_->SetMultiLine(true);
this doesn't make a difference in English but will matter for languages with
wider strings.

https://codereview.chromium.org/1673403002/diff/1/chrome/browser/ui/views/web...
File chrome/browser/ui/views/website_settings/permissions_bubble_view.cc (left):

https://codereview.chromium.org/1673403002/diff/1/chrome/browser/ui/views/web...
chrome/browser/ui/views/website_settings/permissions_bubble_view.cc:238:
views::BoxLayout::kHorizontal, kPermissionIndentSpacing, 0, 0));
this 0 used to be kBubbleOuterMargin (5) but I deleted it because I was getting
rid of custom margins. Turns out that was over-zealous because we do need some
value here, so I changed to kItemLabelSpacing.

[msw, 2016-02-09 00:04:36]

https://codereview.chromium.org/1673403002/diff/1/chrome/browser/ui/views/web...
File chrome/browser/ui/views/website_settings/permissions_bubble_view.cc (left):

https://codereview.chromium.org/1673403002/diff/1/chrome/browser/ui/views/web...
chrome/browser/ui/views/website_settings/permissions_bubble_view.cc:238:
views::BoxLayout::kHorizontal, kPermissionIndentSpacing, 0, 0));
On 2016/02/08 23:00:49, Evan Stade wrote:
> this 0 used to be kBubbleOuterMargin (5) but I deleted it because I was
getting
> rid of custom margins. Turns out that was over-zealous because we do need some
> value here, so I changed to kItemLabelSpacing.

Is this for 585076? It doesn't seem like a 0 here would have caused too much
padding there, nor do I see where this CL attempts to fix that defect.

https://codereview.chromium.org/1673403002/diff/1/ui/views/layout/layout_cons...
File ui/views/layout/layout_constants.h (left):

https://codereview.chromium.org/1673403002/diff/1/ui/views/layout/layout_cons...
ui/views/layout/layout_constants.h:24: const int kPanelHorizIndentation = 24;
This is still used by chrome/browser/ui/views/uninstall_view.cc

[Evan Stade, 2016-02-09 00:13:19]

Description was changed from

==========
Views - fix up layout of a couple dialogs

- create application shortcuts dialog
- permissions bubble view

BUG=585254, 585076
==========

to

==========
Views - fix up layout of a couple dialogs

- create application shortcuts dialog
- permissions bubble view

BUG=585254, 585014
==========

[Evan Stade, 2016-02-09 00:16:00]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-09 00:17:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673403002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673403002/20001

[commit-bot: I haz the power, 2016-02-09 02:10:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 02:10:31]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-02-09 23:47:58]

https://codereview.chromium.org/1673403002/diff/1/chrome/browser/ui/views/web...
File chrome/browser/ui/views/website_settings/permissions_bubble_view.cc (left):

https://codereview.chromium.org/1673403002/diff/1/chrome/browser/ui/views/web...
chrome/browser/ui/views/website_settings/permissions_bubble_view.cc:238:
views::BoxLayout::kHorizontal, kPermissionIndentSpacing, 0, 0));
On 2016/02/09 00:04:36, msw wrote:
> On 2016/02/08 23:00:49, Evan Stade wrote:
> > this 0 used to be kBubbleOuterMargin (5) but I deleted it because I was
> getting
> > rid of custom margins. Turns out that was over-zealous because we do need
some
> > value here, so I changed to kItemLabelSpacing.
> 
> Is this for 585076? It doesn't seem like a 0 here would have caused too much
> padding there, nor do I see where this CL attempts to fix that defect.

sorry, wrong bug, should have been crbug.com/585014

crbug.com/585076 is not related to my recent bubble work (as you can see the
bisect predates the bubble changes)

https://codereview.chromium.org/1673403002/diff/1/ui/views/layout/layout_cons...
File ui/views/layout/layout_constants.h (left):

https://codereview.chromium.org/1673403002/diff/1/ui/views/layout/layout_cons...
ui/views/layout/layout_constants.h:24: const int kPanelHorizIndentation = 24;
On 2016/02/09 00:04:36, msw wrote:
> This is still used by chrome/browser/ui/views/uninstall_view.cc

thanks -- changed uninstall_view.cc to use kCheckboxIndent. In both cases it's
indenting a checkbox.

[msw, 2016-02-10 00:16:48]

lgtm

[sky, 2016-02-10 16:12:54]

LGTM

[Evan Stade, 2016-02-10 21:41:41]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-02-10 21:42:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1673403002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1673403002/20001

[commit-bot: I haz the power, 2016-02-10 22:44:45]

Description was changed from

==========
Views - fix up layout of a couple dialogs

- create application shortcuts dialog
- permissions bubble view

BUG=585254, 585014
==========

to

==========
Views - fix up layout of a couple dialogs

- create application shortcuts dialog
- permissions bubble view

BUG=585254, 585014
==========

[commit-bot: I haz the power, 2016-02-10 22:44:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:31:53]

Description was changed from

==========
Views - fix up layout of a couple dialogs

- create application shortcuts dialog
- permissions bubble view

BUG=585254, 585014
==========

to

==========
Views - fix up layout of a couple dialogs

- create application shortcuts dialog
- permissions bubble view

BUG=585254, 585014

Committed: https://crrev.com/4605d229e0791644f93df899734c5c78ba683fc0
Cr-Commit-Position: refs/heads/master@{#374756}
==========

[commit-bot: I haz the power, 2016-02-16 22:31:54]

Patchset 2 (id:??) landed as
https://crrev.com/4605d229e0791644f93df899734c5c78ba683fc0
Cr-Commit-Position: refs/heads/master@{#374756}