Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4229)

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 1673403002: Views - fix up layout of a couple dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: msw review Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/uninstall_view.cc ('k') | ui/views/layout/layout_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
index 451cda3d930734d2fd05c69c4991e11329a464c0..a1ae82edf96dec2f8881c502dcb8f4cc6282a117 100644
--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
@@ -44,6 +44,7 @@
#include "ui/views/controls/menu/menu_runner.h"
#include "ui/views/layout/box_layout.h"
#include "ui/views/layout/grid_layout.h"
+#include "ui/views/layout/layout_constants.h"
namespace {
@@ -56,9 +57,6 @@ const int kButtonBorderSize = 2;
// (Square) pixel size of icon.
const int kIconSize = 18;
-// Number of pixels to indent the permission request labels.
-const int kPermissionIndentSpacing = 12;
-
} // namespace
// This class is a MenuButton which is given a PermissionMenuModel. It
@@ -235,7 +233,8 @@ PermissionsBubbleDelegateView::PermissionsBubbleDelegateView(
views::View* label_container = new views::View();
label_container->SetLayoutManager(new views::BoxLayout(
- views::BoxLayout::kHorizontal, kPermissionIndentSpacing, 0, 0));
+ views::BoxLayout::kHorizontal, views::kCheckboxIndent, 0,
+ views::kItemLabelSpacing));
views::ImageView* icon = new views::ImageView();
gfx::VectorIconId vector_id = requests[index]->GetVectorIconId();
if (vector_id != gfx::VectorIconId::VECTOR_ICON_NONE) {
« no previous file with comments | « chrome/browser/ui/views/uninstall_view.cc ('k') | ui/views/layout/layout_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698