Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1673323002: Remove gl_bindings_skia_in_process (dead code) (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
CC:
chromium-reviews, piman, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove gl_bindings_skia_in_process (dead code) BUG=442811 Committed: https://crrev.com/3b5f500be63c7e3a0b2572756dcdf516bca64a99 Cr-Commit-Position: refs/heads/master@{#374255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1020 lines) Patch
M ui/gl/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/gl/gl.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gl/gl_bindings_skia_in_process.h View 1 chunk +0 lines, -20 lines 0 comments Download
D ui/gl/gl_bindings_skia_in_process.cc View 1 chunk +0 lines, -995 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (9 generated)
bsalomon
While making local changes to the command buffer bindings I discovered that these bindings are ...
4 years, 10 months ago (2016-02-08 18:27:23 UTC) #2
piman
lgtm
4 years, 10 months ago (2016-02-08 18:48:50 UTC) #4
Ken Russell (switch to Gerrit)
Hooray for deleting code! lgtm.
4 years, 10 months ago (2016-02-08 19:01:51 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1677123002 Patch 1). Please resolve the dependency and ...
4 years, 10 months ago (2016-02-08 19:05:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673323002/1
4 years, 10 months ago (2016-02-08 21:05:39 UTC) #10
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
4 years, 10 months ago (2016-02-08 22:55:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673323002/1
4 years, 10 months ago (2016-02-09 01:16:32 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 01:30:49 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 01:31:57 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b5f500be63c7e3a0b2572756dcdf516bca64a99
Cr-Commit-Position: refs/heads/master@{#374255}

Powered by Google App Engine
This is Rietveld 408576698