runtime/vm/flow_graph_compiler_x64.cc - Issue 1673253002: EmitEqualityRegRegCompare on x64 must use cmpq not cmpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 1673253002: EmitEqualityRegRegCompare on x64 must use cmpq not cmpl. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_x64.cc

diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc

index 68004fb5e9067c22314dcc8b4eaafe40fef258ee..e5c09b06e3edc257062b31d2ec72dd4dabbf89dc 100644

--- a/runtime/vm/flow_graph_compiler_x64.cc

+++ b/runtime/vm/flow_graph_compiler_x64.cc

@@ -1448,7 +1448,7 @@ Condition FlowGraphCompiler::EmitEqualityRegRegCompare(

__ popq(right);

__ popq(left);

} else {

- __ cmpl(left, right);

+ __ CompareRegisters(left, right);

}

return EQUAL;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »