Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 1673253002: EmitEqualityRegRegCompare on x64 must use cmpq not cmpl. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1430 matching lines...) Expand 10 before | Expand all | Expand 10 after
1441 } 1441 }
1442 if (token_pos.IsReal()) { 1442 if (token_pos.IsReal()) {
1443 AddCurrentDescriptor(RawPcDescriptors::kRuntimeCall, 1443 AddCurrentDescriptor(RawPcDescriptors::kRuntimeCall,
1444 Thread::kNoDeoptId, 1444 Thread::kNoDeoptId,
1445 token_pos); 1445 token_pos);
1446 } 1446 }
1447 // Stub returns result in flags (result of a cmpq, we need ZF computed). 1447 // Stub returns result in flags (result of a cmpq, we need ZF computed).
1448 __ popq(right); 1448 __ popq(right);
1449 __ popq(left); 1449 __ popq(left);
1450 } else { 1450 } else {
1451 __ cmpl(left, right); 1451 __ CompareRegisters(left, right);
1452 } 1452 }
1453 return EQUAL; 1453 return EQUAL;
1454 } 1454 }
1455 1455
1456 1456
1457 // This function must be in sync with FlowGraphCompiler::RecordSafepoint and 1457 // This function must be in sync with FlowGraphCompiler::RecordSafepoint and
1458 // FlowGraphCompiler::SlowPathEnvironmentFor. 1458 // FlowGraphCompiler::SlowPathEnvironmentFor.
1459 void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) { 1459 void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) {
1460 #if defined(DEBUG) 1460 #if defined(DEBUG)
1461 locs->CheckWritableInputs(); 1461 locs->CheckWritableInputs();
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
1813 __ movups(reg, Address(RSP, 0)); 1813 __ movups(reg, Address(RSP, 0));
1814 __ AddImmediate(RSP, Immediate(kFpuRegisterSize)); 1814 __ AddImmediate(RSP, Immediate(kFpuRegisterSize));
1815 } 1815 }
1816 1816
1817 1817
1818 #undef __ 1818 #undef __
1819 1819
1820 } // namespace dart 1820 } // namespace dart
1821 1821
1822 #endif // defined TARGET_ARCH_X64 1822 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698