Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1673203002: Add override qualifier to SVGStaticStringList::setBaseValueAsString (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
davve, Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add override qualifier to SVGStaticStringList::setBaseValueAsString Overrides method from SVGAnimatedPropertyBase. Committed: https://crrev.com/b37d4f2aeeb179570fc01b103153921eae7a10ee Cr-Commit-Position: refs/heads/master@{#374127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/svg/SVGStaticStringList.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
fs
4 years, 10 months ago (2016-02-08 14:08:42 UTC) #2
Stephen Chennney
lgtm
4 years, 10 months ago (2016-02-08 14:32:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1673203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1673203002/1
4 years, 10 months ago (2016-02-08 14:34:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-08 15:37:16 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-08 15:38:10 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b37d4f2aeeb179570fc01b103153921eae7a10ee
Cr-Commit-Position: refs/heads/master@{#374127}

Powered by Google App Engine
This is Rietveld 408576698