third_party/WebKit/Source/core/svg/SVGStaticStringList.h - Issue 1673203002: Add override qualifier to SVGStaticStringList::setBaseValueAsString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGStaticStringList.h

Issue 1673203002: Add override qualifier to SVGStaticStringList::setBaseValueAsString (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/svg/SVGStaticStringList.h

diff --git a/third_party/WebKit/Source/core/svg/SVGStaticStringList.h b/third_party/WebKit/Source/core/svg/SVGStaticStringList.h

index 430f4ce44ebf9f6b23dc9f52c531385f42c47323..6abf71d4d946f707692a25df56dada29ee05e948 100644

--- a/third_party/WebKit/Source/core/svg/SVGStaticStringList.h

+++ b/third_party/WebKit/Source/core/svg/SVGStaticStringList.h

@@ -59,7 +59,7 @@ public:

void animationEnded() override;

bool needsSynchronizeAttribute() override;

- SVGParsingError setBaseValueAsString(const String&);

+ SVGParsingError setBaseValueAsString(const String&) override;

SVGStringList* value() { return m_value.get(); }

SVGStringListTearOff* tearOff();

« no previous file with comments | « no previous file | no next file » | no next file with comments »