Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 16732002: remove equality kind from compare nil ic (Closed)

Created:
7 years, 6 months ago by oliv
Modified:
7 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

use compare nil ic only for non-strict equality. strict-equality only has one check and cannot deopt. should therefore not be part of the stub. BUG= R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15045

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -91 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 chunks +2 lines, -6 lines 0 comments Download
M src/code-stubs.h View 1 4 chunks +6 lines, -17 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +11 lines, -20 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 chunks +13 lines, -13 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M src/ic.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic.cc View 1 2 3 chunks +2 lines, -11 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/v8.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M test/cctest/test-compare-nil-ic-stub.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oliv
7 years, 6 months ago (2013-06-10 11:17:08 UTC) #1
rossberg
LGTM with nits https://codereview.chromium.org/16732002/diff/2001/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): https://codereview.chromium.org/16732002/diff/2001/src/arm/full-codegen-arm.cc#newcode4777 src/arm/full-codegen-arm.cc:4777: nil); Nit: fits on previous line ...
7 years, 6 months ago (2013-06-10 11:43:54 UTC) #2
oliv
7 years, 6 months ago (2013-06-10 15:47:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r15045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698