Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: test/cctest/test-compare-nil-ic-stub.cc

Issue 16732002: remove equality kind from compare nil ic (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2013 the V8 project authors. All rights reserved. 1 // Copyright 2006-2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 28 matching lines...) Expand all
39 TEST(TypeConstructors) { 39 TEST(TypeConstructors) {
40 Types types; 40 Types types;
41 types.Add(CompareNilICStub::MONOMORPHIC_MAP); 41 types.Add(CompareNilICStub::MONOMORPHIC_MAP);
42 Types types2(types); 42 Types types2(types);
43 CHECK_EQ(types.ToIntegral(), types2.ToIntegral()); 43 CHECK_EQ(types.ToIntegral(), types2.ToIntegral());
44 } 44 }
45 45
46 TEST(ExternalICStateParsing) { 46 TEST(ExternalICStateParsing) {
47 Types types; 47 Types types;
48 types.Add(CompareNilICStub::UNDEFINED); 48 types.Add(CompareNilICStub::UNDEFINED);
49 CompareNilICStub stub(kNonStrictEquality, kUndefinedValue, types); 49 CompareNilICStub stub(kUndefinedValue, types);
50 CompareNilICStub stub2(stub.GetExtraICState()); 50 CompareNilICStub stub2(stub.GetExtraICState());
51 CHECK_EQ(stub.GetKind(), stub2.GetKind());
52 CHECK_EQ(stub.GetNilValue(), stub2.GetNilValue()); 51 CHECK_EQ(stub.GetNilValue(), stub2.GetNilValue());
53 CHECK_EQ(stub.GetTypes().ToIntegral(), stub2.GetTypes().ToIntegral()); 52 CHECK_EQ(stub.GetTypes().ToIntegral(), stub2.GetTypes().ToIntegral());
54 } 53 }
55 54
56 TEST(SettingTypes) { 55 TEST(SettingTypes) {
57 Types state; 56 Types state;
58 CHECK(state.IsEmpty()); 57 CHECK(state.IsEmpty());
59 state.Add(CompareNilICStub::NULL_TYPE); 58 state.Add(CompareNilICStub::NULL_TYPE);
60 CHECK(!state.IsEmpty()); 59 CHECK(!state.IsEmpty());
61 CHECK(state.Contains(CompareNilICStub::NULL_TYPE)); 60 CHECK(state.Contains(CompareNilICStub::NULL_TYPE));
(...skipping 15 matching lines...) Expand all
77 TEST(FullCompare) { 76 TEST(FullCompare) {
78 Types state; 77 Types state;
79 CHECK(Types::FullCompare() != state); 78 CHECK(Types::FullCompare() != state);
80 state.Add(CompareNilICStub::UNDEFINED); 79 state.Add(CompareNilICStub::UNDEFINED);
81 CHECK(state != Types::FullCompare()); 80 CHECK(state != Types::FullCompare());
82 state.Add(CompareNilICStub::NULL_TYPE); 81 state.Add(CompareNilICStub::NULL_TYPE);
83 CHECK(state != Types::FullCompare()); 82 CHECK(state != Types::FullCompare());
84 state.Add(CompareNilICStub::UNDETECTABLE); 83 state.Add(CompareNilICStub::UNDETECTABLE);
85 CHECK(state == Types::FullCompare()); 84 CHECK(state == Types::FullCompare());
86 } 85 }
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698