Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 1673113002: Move WebGL1 attachment image type / attachment point matching check to command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index 4bd1cdd4f6c1523b1403d30333ed701f08069e07..d8edc1f7f5a5063d94bfea3c2650f8d3cd7cb58d 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -564,6 +564,15 @@ void FeatureInfo::InitializeFeatures() {
GL_DEPTH_STENCIL);
}
validators_.render_buffer_format.AddValue(GL_DEPTH24_STENCIL8);
+ if (context_type_ == CONTEXT_TYPE_WEBGL1) {
+ // For glFramebufferRenderbuffer and glFramebufferTexture2D calls with
+ // attachment == GL_DEPTH_STENCIL_ATTACHMENT, we always split into two
+ // calls, one with attachment == GL_DEPTH_ATTACHMENT, and one with
+ // attachment == GL_STENCIL_ATTACHMENT. So even if the underlying driver
+ // is ES2 where GL_DEPTH_STENCIL_ATTACHMENT isn't accepted, it is still
+ // OK.
+ validators_.attachment.AddValue(GL_DEPTH_STENCIL_ATTACHMENT);
+ }
}
if (gl_version_info_->is_es3 ||
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698