Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: runtime/vm/object.h

Issue 1672873003: Bailout if field state changed during background compilation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index eed376be2152b218585740f514db5420dd8771de..26e68cebbeb9b7c8afe989025b91003d41c44463 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -493,6 +493,11 @@ class Object {
return *speculative_inlining_error_;
}
+ static const LanguageError& background_compilation_error() {
+ ASSERT(background_compilation_error_ != NULL);
+ return *background_compilation_error_;
+ }
+
static const Array& vm_isolate_snapshot_object_table() {
ASSERT(vm_isolate_snapshot_object_table_ != NULL);
return *vm_isolate_snapshot_object_table_;
@@ -828,6 +833,7 @@ class Object {
static LanguageError* snapshot_writer_error_;
static LanguageError* branch_offset_error_;
static LanguageError* speculative_inlining_error_;
+ static LanguageError* background_compilation_error_;
static Array* vm_isolate_snapshot_object_table_;
static Type* dynamic_type_;
static Type* void_type_;
@@ -2670,11 +2676,10 @@ class Function : public Object {
void SaveICDataMap(
const ZoneGrowableArray<const ICData*>& deopt_id_to_ic_data,
const Array& edge_counters_array) const;
- // Uses saved ICData to populate the table 'deopt_id_to_ic_data'. Clone
+ // Uses 'ic_data_array' to populate the table 'deopt_id_to_ic_data'. Clone
// descriptors if 'clone_descriptors' true.
- void RestoreICDataMap(
- ZoneGrowableArray<const ICData*>* deopt_id_to_ic_data,
- bool clone_descriptors) const;
+ void RestoreICDataMap(ZoneGrowableArray<const ICData*>* deopt_id_to_ic_data,
+ bool clone_descriptors) const;
RawArray* ic_data_array() const;
void ClearICDataArray() const;
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698