Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1672873003: Bailout if field state changed during background compilation. (Closed)

Created:
4 years, 10 months ago by srdjan
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bailout if field state changed during background compilation. Bailout if deferred loading cleared ic_data_array. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5cba052d70b5d957686fc24e9c5a34f979813e34

Patch Set 1 #

Patch Set 2 : Restore default #

Patch Set 3 : Add include #

Patch Set 4 : Fix issue with deferred loading #

Patch Set 5 : g #

Patch Set 6 : e #

Patch Set 7 : g #

Patch Set 8 : cleanup #

Patch Set 9 : a #

Total comments: 2

Patch Set 10 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -13 lines) Patch
M runtime/vm/block_scheduler.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/compiler.h View 1 2 3 4 5 6 7 8 9 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 3 4 5 6 7 3 chunks +16 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 3 4 5 6 7 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 7 8 9 3 chunks +9 lines, -4 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 8 6 chunks +12 lines, -1 line 0 comments Download
M runtime/vm/source_report.cc View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
srdjan
4 years, 10 months ago (2016-02-08 19:13:58 UTC) #3
rmacnak
lgtm https://codereview.chromium.org/1672873003/diff/160001/runtime/vm/compiler.h File runtime/vm/compiler.h (right): https://codereview.chromium.org/1672873003/diff/160001/runtime/vm/compiler.h#newcode98 runtime/vm/compiler.h:98: static void AbortBackgroundCompilation(intptr_t deopt_id); Add comment that this ...
4 years, 10 months ago (2016-02-08 20:24:25 UTC) #4
srdjan
https://codereview.chromium.org/1672873003/diff/160001/runtime/vm/compiler.h File runtime/vm/compiler.h (right): https://codereview.chromium.org/1672873003/diff/160001/runtime/vm/compiler.h#newcode98 runtime/vm/compiler.h:98: static void AbortBackgroundCompilation(intptr_t deopt_id); On 2016/02/08 20:24:25, rmacnak wrote: ...
4 years, 10 months ago (2016-02-08 20:30:16 UTC) #5
srdjan
4 years, 10 months ago (2016-02-08 20:51:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #10 (id:180001) manually as
5cba052d70b5d957686fc24e9c5a34f979813e34 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698