runtime/vm/flow_graph_inliner.cc - Issue 1672873003: Bailout if field state changed during background compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_inliner.cc

Issue 1672873003: Bailout if field state changed during background compilation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: a Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_inliner.cc

diff --git a/runtime/vm/flow_graph_inliner.cc b/runtime/vm/flow_graph_inliner.cc

index 91563dd79fe7d1f7582ba77348c2a700a8137e7b..0ade97da9bed99208d740dd8feb4e652bae098d3 100644

--- a/runtime/vm/flow_graph_inliner.cc

+++ b/runtime/vm/flow_graph_inliner.cc

@@ -707,6 +707,10 @@ class CallSiteInliner : public ValueObject {

new(Z) ZoneGrowableArray<const ICData*>();

const bool clone_descriptors = Compiler::IsBackgroundCompilation();

function.RestoreICDataMap(ic_data_array, clone_descriptors);

+ if (Compiler::IsBackgroundCompilation() &&

+ (function.ic_data_array() == Array::null())) {

+ Compiler::AbortBackgroundCompilation(Thread::kNoDeoptId);

+ }

// Build the callee graph.

InlineExitCollector* exit_collector =