runtime/vm/regexp_parser.cc - Issue 1672853002: Move sticky_error_ from isolate to thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/regexp_parser.cc

Issue 1672853002: Move sticky_error_ from isolate to thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/regexp_parser.cc

diff --git a/runtime/vm/regexp_parser.cc b/runtime/vm/regexp_parser.cc

index b24e8ca462ad8abdbc436922df755501987f73dc..7b0e01a478def31d88085172c21432df03af6038 100644

--- a/runtime/vm/regexp_parser.cc

+++ b/runtime/vm/regexp_parser.cc

@@ -1064,7 +1064,7 @@ bool RegExpParser::ParseRegExp(const String& input,

result->capture_count = capture_count;

} else {

ASSERT(!result->error.IsNull());

- Isolate::Current()->object_store()->clear_sticky_error();

+ Thread::Current()->clear_sticky_error();

// Throw a FormatException on parsing failures.

const String& message = String::Handle(

« no previous file with comments | « runtime/vm/precompiler.cc ('k') | runtime/vm/service_isolate.cc » ('j') | no next file with comments »