Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1672793002:
Cherry pick underflow fix. (Closed)
|
Created:
4 years, 10 months ago by eustas Modified:
4 years, 10 months ago Reviewers:
jochen (gone - plz use gerrit), sky, Kunihiko Sakamoto, jam, Nico, klobag.chromium, cpu_(ooo_6.6-7.5), bashi CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@2564 Target Ref:
refs/pending/branch-heads/2564 Project:
chromium Visibility:
Public. |
DescriptionCherry pick underflow fix.
BUG=583607
Review URL: https://codereview.chromium.org/1662313002
Cr-Commit-Position: refs/heads/master@{#373736}
(cherry picked from commit 7716418a27d561ee295a99f11fd3865580748de2)
NOTRY=true
NOPRESUBMIT=true
TBR=ksakamoto@chromium.org
Patch Set 1 #
Messages
Total messages: 29 (15 generated)
Please LGTM, mark for commit ASAP
Description was changed from ========== Cherry pick underflow fix. BUG=583607 Review URL: https://codereview.chromium.org/1662313002 Cr-Commit-Position: refs/heads/master@{#373736} (cherry picked from commit 7716418a27d561ee295a99f11fd3865580748de2) ========== to ========== Cherry pick underflow fix. BUG=583607 Review URL: https://codereview.chromium.org/1662313002 Cr-Commit-Position: refs/heads/master@{#373736} (cherry picked from commit 7716418a27d561ee295a99f11fd3865580748de2) NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by eustas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672793002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Please, LGTM and mark for commit ASAP. Thank you.
Note that the owners in third_party is there for new packages, so people don't add new things without propper betting and with an incompatible license. In the case of a change just have a relevant person review and just TBR=cpu
Description was changed from ========== Cherry pick underflow fix. BUG=583607 Review URL: https://codereview.chromium.org/1662313002 Cr-Commit-Position: refs/heads/master@{#373736} (cherry picked from commit 7716418a27d561ee295a99f11fd3865580748de2) NOTRY=true NOPRESUBMIT=true ========== to ========== Cherry pick underflow fix. BUG=583607 Review URL: https://codereview.chromium.org/1662313002 Cr-Commit-Position: refs/heads/master@{#373736} (cherry picked from commit 7716418a27d561ee295a99f11fd3865580748de2) NOTRY=true NOPRESUBMIT=true TBR=cpu ==========
The CQ bit was checked by eustas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672793002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Cherry pick underflow fix. BUG=583607 Review URL: https://codereview.chromium.org/1662313002 Cr-Commit-Position: refs/heads/master@{#373736} (cherry picked from commit 7716418a27d561ee295a99f11fd3865580748de2) NOTRY=true NOPRESUBMIT=true TBR=cpu ========== to ========== Cherry pick underflow fix. BUG=583607 Review URL: https://codereview.chromium.org/1662313002 Cr-Commit-Position: refs/heads/master@{#373736} (cherry picked from commit 7716418a27d561ee295a99f11fd3865580748de2) NOTRY=true NOPRESUBMIT=true TBR=ksakamoto@chromium.org ==========
The CQ bit was checked by eustas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672793002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
rubberstamp lgtm
The CQ bit was checked by eustas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672793002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by eustas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672793002/1
Message was sent while issue was closed.
Description was changed from ========== Cherry pick underflow fix. BUG=583607 Review URL: https://codereview.chromium.org/1662313002 Cr-Commit-Position: refs/heads/master@{#373736} (cherry picked from commit 7716418a27d561ee295a99f11fd3865580748de2) NOTRY=true NOPRESUBMIT=true TBR=ksakamoto@chromium.org ========== to ========== Cherry pick underflow fix. BUG=583607 Review URL: https://codereview.chromium.org/1662313002 Cr-Commit-Position: refs/heads/master@{#373736} (cherry picked from commit 7716418a27d561ee295a99f11fd3865580748de2) NOTRY=true NOPRESUBMIT=true TBR=ksakamoto@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
