Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1662313002: Cherry pick underflow fix. (Closed)

Created:
4 years, 10 months ago by eustas
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cherry pick underflow fix. BUG=583607 Committed: https://crrev.com/7716418a27d561ee295a99f11fd3865580748de2 Cr-Commit-Position: refs/heads/master@{#373736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/brotli/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/brotli/dec/decode.c View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
eustas
4 years, 10 months ago (2016-02-04 16:50:49 UTC) #2
bashi
Could you explain why do you cherry-pick it instead of updating to 37a320dd81db8d546cd24a45b4c61d87b45dcade?
4 years, 10 months ago (2016-02-04 23:22:22 UTC) #3
Kunihiko Sakamoto
I think this patch is intended to be merged to M49, so cherrypick lgtm. (It'd ...
4 years, 10 months ago (2016-02-05 01:49:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1662313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1662313002/1
4 years, 10 months ago (2016-02-05 01:52:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 03:17:52 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 03:18:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7716418a27d561ee295a99f11fd3865580748de2
Cr-Commit-Position: refs/heads/master@{#373736}

Powered by Google App Engine
This is Rietveld 408576698