net/quic/quic_connection_logger.h - Issue 1672513002: Expose packet loss counts from QUIC to NetworkQualityEstimator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_connection_logger.h

Issue 1672513002: Expose packet loss counts from QUIC to NetworkQualityEstimator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed bengr comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/base/socket_performance_watcher_factory.h ('K') | « net/base/socket_performance_watcher_factory.h ('k') | net/quic/quic_connection_logger.cc » ('j') | net/quic/quic_connection_logger.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/quic/quic_connection_logger.h

diff --git a/net/quic/quic_connection_logger.h b/net/quic/quic_connection_logger.h

index 132a9ea68bb9e4dcbcd8db970e857a340895dc30..d2efd0697b2a382b36c08f4c8079492b4e93c00b 100644

--- a/net/quic/quic_connection_logger.h

+++ b/net/quic/quic_connection_logger.h

@@ -123,6 +123,13 @@ class NET_EXPORT_PRIVATE QuicConnectionLogger

// histograms for specific connection types.

void RecordLossHistograms() const;

+ // Reports the counts of the packets received on the uplink (remote endpoint

bengr 2016/02/19 00:45:09 I think you just mean "reports packet receptions t

tbansal1 2016/02/26 01:15:00 Done.

+ // to this device) to the |socket_performance_watcher_|. Called everytime a

+ // packet is received. |previous_largest_received_packet_number| is the value

+ // of |largest_received_packet_number_| before the packet was received.

+ void ReportPacketCounts(

+ QuicPacketCount previous_largest_received_packet_number) const;

BoundNetLog net_log_;

QuicSpdySession* session_; // Unowned.

// The last packet number received.