Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: net/quic/quic_connection_logger.h

Issue 1672513002: Expose packet loss counts from QUIC to NetworkQualityEstimator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed bengr comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_CONNECTION_LOGGER_H_ 5 #ifndef NET_QUIC_QUIC_CONNECTION_LOGGER_H_
6 #define NET_QUIC_QUIC_CONNECTION_LOGGER_H_ 6 #define NET_QUIC_QUIC_CONNECTION_LOGGER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <bitset> 10 #include <bitset>
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 static void AddTo21CumulativeHistogram(base::HistogramBase* histogram, 116 static void AddTo21CumulativeHistogram(base::HistogramBase* histogram,
117 int bit_mask_of_packets, 117 int bit_mask_of_packets,
118 int valid_bits_in_mask); 118 int valid_bits_in_mask);
119 // For connections longer than 21 received packets, this call will calculate 119 // For connections longer than 21 received packets, this call will calculate
120 // the overall packet loss rate, and record it into a histogram. 120 // the overall packet loss rate, and record it into a histogram.
121 void RecordAggregatePacketLossRate() const; 121 void RecordAggregatePacketLossRate() const;
122 // At destruction time, this records results of |pacaket_received_| into 122 // At destruction time, this records results of |pacaket_received_| into
123 // histograms for specific connection types. 123 // histograms for specific connection types.
124 void RecordLossHistograms() const; 124 void RecordLossHistograms() const;
125 125
126 // Reports the counts of the packets received on the uplink (remote endpoint
bengr 2016/02/19 00:45:09 I think you just mean "reports packet receptions t
tbansal1 2016/02/26 01:15:00 Done.
127 // to this device) to the |socket_performance_watcher_|. Called everytime a
128 // packet is received. |previous_largest_received_packet_number| is the value
129 // of |largest_received_packet_number_| before the packet was received.
130 void ReportPacketCounts(
131 QuicPacketCount previous_largest_received_packet_number) const;
132
126 BoundNetLog net_log_; 133 BoundNetLog net_log_;
127 QuicSpdySession* session_; // Unowned. 134 QuicSpdySession* session_; // Unowned.
128 // The last packet number received. 135 // The last packet number received.
129 QuicPacketNumber last_received_packet_number_; 136 QuicPacketNumber last_received_packet_number_;
130 // The size of the most recently received packet. 137 // The size of the most recently received packet.
131 size_t last_received_packet_size_; 138 size_t last_received_packet_size_;
132 // The size of the previously received packet. 139 // The size of the previously received packet.
133 size_t previous_received_packet_size_; 140 size_t previous_received_packet_size_;
134 // The timestamp of last packet sent. 141 // The timestamp of last packet sent.
135 QuicTime last_packet_sent_time_; 142 QuicTime last_packet_sent_time_;
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 // Receives notifications regarding the performance of the underlying socket 194 // Receives notifications regarding the performance of the underlying socket
188 // for the QUIC connection. May be null. 195 // for the QUIC connection. May be null.
189 const scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher_; 196 const scoped_ptr<SocketPerformanceWatcher> socket_performance_watcher_;
190 197
191 DISALLOW_COPY_AND_ASSIGN(QuicConnectionLogger); 198 DISALLOW_COPY_AND_ASSIGN(QuicConnectionLogger);
192 }; 199 };
193 200
194 } // namespace net 201 } // namespace net
195 202
196 #endif // NET_QUIC_QUIC_CONNECTION_LOGGER_H_ 203 #endif // NET_QUIC_QUIC_CONNECTION_LOGGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698