Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 167243002: Revert 251087 "Add wallpaper api tests" (Closed)

Created:
6 years, 10 months ago by sky
Modified:
6 years, 10 months ago
Reviewers:
bshe
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 251087 "Add wallpaper api tests" > Add wallpaper api tests > > This CL add the following tests: > 1. test chrome.setWallpaper can set ChromeOS wallpaper from jpg or png formatted arraybuffer. > 2. test chrome.setWallpaper can set ChromeOS wallpaper from a valid url that point to a jpg or png image. > 3. test an invalide URL wont set wallpaper > 4. test a new wallpaper request will cancel previous unfinished request > > > BUG=176183 > > Review URL: https://codereview.chromium.org/153093010 AFAICT this failed as soon as you landed it. Here's output from one of the bots: ExtensionApiTest.Wallpaper (run #1): [ RUN ] ExtensionApiTest.Wallpaper [21364:21364:0213/150838:1514562885:ERROR:audio_manager_pulse.cc(248)] Failed to connect to the context. Error: Connection refused Xlib: extension "RANDR" missing on display ":9". [7:7:0213/150839:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: renderer. [21409:21409:0213/230839:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: gpu-process. [15:15:0213/150840:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: renderer. [24:24:0213/150840:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: utility. Corrupt JPEG data: premature end of data segment [21364:21364:0213/150841:1516721525:INFO:CONSOLE(0)] "[SUCCESS] setJpgWallpaperFromAppLocalFile", source: chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html (0) [31:31:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: utility. [21364:21364:0213/150841:1516803158:INFO:CONSOLE(0)] "[SUCCESS] setPngWallpaperFromAppLocalFile", source: chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html (0) [38:38:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: utility. Corrupt JPEG data: premature end of data segment [21364:21364:0213/150841:1517187827:INFO:CONSOLE(0)] "[SUCCESS] setJpgWallpaperFromURL", source: chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html (0) [45:45:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: utility. [21364:21364:0213/150841:1517523379:INFO:CONSOLE(0)] "[SUCCESS] setPngWallpaperFromURL", source: chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html (0) [21364:21446:0213/150841:1517544840:WARNING:embedded_test_server.cc(231)] Request not handled. Returning 404: /extensions/api_test/wallpaper/test1.jpg [52:52:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: utility. /usr/include/c++/4.6/debug/vector:320:error: attempt to subscript container with out-of-bounds index 0, but container only holds 0 elements. Objects involved in the operation: sequence "this" @ 0x0x7ffffdb6a470 { } at: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10341/steps/browser_tests/logs/Wallpaper TBR=bshe@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -130 lines) Patch
D trunk/src/chrome/browser/chromeos/extensions/wallpaper_apitest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/wallpaper/manifest.json View 1 chunk +0 lines, -13 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/wallpaper/test.jpg View Binary file 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/wallpaper/test.js View 1 chunk +0 lines, -104 lines 0 comments Download
D trunk/src/chrome/test/data/extensions/api_test/wallpaper/test.png View Binary file 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
6 years, 10 months ago (2014-02-14 17:41:54 UTC) #1
sky
6 years, 10 months ago (2014-02-14 17:42:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r251366.

Powered by Google App Engine
This is Rietveld 408576698