Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 153093010: Add wallpaper api tests (Closed)

Created:
6 years, 10 months ago by bshe
Modified:
6 years, 10 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add wallpaper api tests This CL add the following tests: 1. test chrome.setWallpaper can set ChromeOS wallpaper from jpg or png formatted arraybuffer. 2. test chrome.setWallpaper can set ChromeOS wallpaper from a valid url that point to a jpg or png image. 3. test an invalide URL wont set wallpaper 4. test a new wallpaper request will cancel previous unfinished request BUG=176183 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251087

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -11 lines) Patch
A + chrome/browser/chromeos/extensions/wallpaper_apitest.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/wallpaper/manifest.json View 1 2 1 chunk +5 lines, -7 lines 0 comments Download
A + chrome/test/data/extensions/api_test/wallpaper/test.jpg View Binary file 0 comments Download
A chrome/test/data/extensions/api_test/wallpaper/test.js View 1 1 chunk +104 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/wallpaper/test.png View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
bshe
Hi Mike. Do you mind to take a look at this CL? wallpaper API has ...
6 years, 10 months ago (2014-02-06 00:41:11 UTC) #1
bshe
On 2014/02/06 00:41:11, bshe wrote: > Hi Mike. > > Do you mind to take ...
6 years, 10 months ago (2014-02-12 21:22:05 UTC) #2
miket_OOO
On 2014/02/12 21:22:05, bshe wrote: > On 2014/02/06 00:41:11, bshe wrote: > > Hi Mike. ...
6 years, 10 months ago (2014-02-12 22:22:38 UTC) #3
bshe
The CQ bit was checked by bshe@chromium.org
6 years, 10 months ago (2014-02-13 15:34:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/153093010/140001
6 years, 10 months ago (2014-02-13 15:36:45 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 18:27:52 UTC) #6
Message was sent while issue was closed.
Change committed as 251087

Powered by Google App Engine
This is Rietveld 408576698