Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1672263002: Move instrumentation tests on linux_android_rel_ng src-side. (Closed)

Created:
4 years, 10 months ago by ghost stip (do not use)
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move instrumentation tests on linux_android_rel_ng src-side. See https://chromiumcodereview.appspot.com/1676693004/ for fyi example. The CL to remove these build-side is https://codereview.chromium.org/1679703004. BUG=525873 Committed: https://crrev.com/d86ef474b5c637e952223910292f8656f219baad Cr-Commit-Position: refs/heads/master@{#374647}

Patch Set 1 #

Patch Set 2 : Also do dbg builds. #

Total comments: 1

Patch Set 3 : ChromePublicTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M testing/buildbot/chromium.linux.json View 1 2 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
bpastene
https://codereview.chromium.org/1672263002/diff/20001/testing/buildbot/chromium.linux.json File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/1672263002/diff/20001/testing/buildbot/chromium.linux.json#newcode265 testing/buildbot/chromium.linux.json:265: "test": "ChromePublic" Try with s/ChromePublic/ChromePublicTest/
4 years, 10 months ago (2016-02-06 00:56:24 UTC) #3
ghost stip (do not use)
ptal! bpastene/jbudorick: review dpranke: OWNERS
4 years, 10 months ago (2016-02-08 17:48:13 UTC) #6
jbudorick
lgtm % comments on the build/ side review
4 years, 10 months ago (2016-02-08 18:01:08 UTC) #7
Dirk Pranke
lgtm, but I recommend that you don't abbreviate "larng" in the subject and description of ...
4 years, 10 months ago (2016-02-08 21:18:29 UTC) #8
ghost stip (do not use)
Generator seems to be working on https://build.chromium.org/p/chromium.fyi/builders/Android%20Cloud%20Tests (those steps have failed) and work on l_a_r_ng ...
4 years, 10 months ago (2016-02-10 10:57:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672263002/40001
4 years, 10 months ago (2016-02-10 10:57:54 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-10 12:44:20 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 12:45:32 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d86ef474b5c637e952223910292f8656f219baad
Cr-Commit-Position: refs/heads/master@{#374647}

Powered by Google App Engine
This is Rietveld 408576698