Remove build-side specification of instrumentation tests.

Remove build-side specification of instrumentation tests.

The CL to add them src-side is https://chromiumcodereview.appspot.com/1672263002/.

BUG=525873
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298703

[ghost stip (do not use), 2016-02-08 17:47:22]

Description was changed from

==========
Remove build-side specification of instrumentation tests.

The CL to add them src-side is
https://chromiumcodereview.appspot.com/1672263002/.

BUG=525873
==========

to

==========
Remove build-side specification of instrumentation tests.

The CL to add them src-side is
https://chromiumcodereview.appspot.com/1672263002/.

BUG=525873
==========

[ghost stip (do not use), 2016-02-08 17:47:22]

stip@chromium.org changed reviewers:
+ bpastene@chromium.org, jbudorick@chromium.org, sergeyberezin@chromium.org

[ghost stip (do not use), 2016-02-08 17:47:52]

bpastene/jbudorick: review
sergeyberezin: OWNERS

[bpastene, 2016-02-08 18:00:37]

lgtm w/ comment

https://codereview.chromium.org/1679703004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_linux.py (left):

https://codereview.chromium.org/1679703004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_linux.py:266:
steps.generate_isolated_script,
Add the new generator here:
steps.generate_instrumentation_test

[jbudorick, 2016-02-08 18:01:00]

code-wise, these changes lgtm.

for deployment, I would prefer:
 - adding these to chromium.android first, just as a sanity check
 - doing this not during MTV-daytime

[Sergey Berezin, 2016-02-08 18:14:25]

rs lgtm

[ghost stip (do not use), 2016-02-08 19:25:26]

updated

will do chromium.android first as a sanity check

https://codereview.chromium.org/1679703004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium_tests/chromium_linux.py (left):

https://codereview.chromium.org/1679703004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium_tests/chromium_linux.py:266:
steps.generate_isolated_script,
On 2016/02/08 18:00:37, bpastene wrote:
> Add the new generator here:
> steps.generate_instrumentation_test

Done.

https://codereview.chromium.org/1679703004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_linux.py (left):

https://codereview.chromium.org/1679703004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_linux.py:266:
steps.generate_isolated_script,
alphabetize

https://codereview.chromium.org/1679703004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_linux.py:323:
steps.generate_instrumentation_test,
alphabetize

https://codereview.chromium.org/1679703004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_linux.py (right):

https://codereview.chromium.org/1679703004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_linux.py:261:
steps.generate_instrumentation_test,
added instrumentation_test

[ghost stip (do not use), 2016-02-10 10:57:24]

Generator seems to be working on
https://build.chromium.org/p/chromium.fyi/builders/Android%20Cloud%20Tests
(those steps have failed) and work on l_a_r_ng trybot. Committing.

[ghost stip (do not use), 2016-02-10 13:21:57]

The CQ bit was checked by stip@chromium.org

[ghost stip (do not use), 2016-02-10 13:21:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org, bpastene@chromium.org, jbudorick@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1679703004/#ps20001
(title: "Add instrumentation test generator for dbg, alphabetize generators.")

[commit-bot: I haz the power, 2016-02-10 13:22:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679703004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679703004/20001

[commit-bot: I haz the power, 2016-02-10 13:23:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 13:23:32]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[ghost stip (do not use), 2016-02-10 13:45:40]

The CQ bit was checked by stip@chromium.org

[ghost stip (do not use), 2016-02-10 13:45:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org, bpastene@chromium.org, jbudorick@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1679703004/#ps40001
(title: "Rerun expectations.")

[commit-bot: I haz the power, 2016-02-10 13:45:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1679703004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1679703004/40001

[commit-bot: I haz the power, 2016-02-10 13:48:20]

Description was changed from

==========
Remove build-side specification of instrumentation tests.

The CL to add them src-side is
https://chromiumcodereview.appspot.com/1672263002/.

BUG=525873
==========

to

==========
Remove build-side specification of instrumentation tests.

The CL to add them src-side is
https://chromiumcodereview.appspot.com/1672263002/.

BUG=525873

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298703
==========

[commit-bot: I haz the power, 2016-02-10 13:48:21]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298703