Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1672243003: Revert "Devtools: Add metrics for drawer views being shown" (Closed)

Created:
4 years, 10 months ago by kozy
Modified:
4 years, 10 months ago
Reviewers:
Steven Holte, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Devtools: Add metrics for drawer views being shown" This reverts commit d4bebfb49bc2fad42b8b1a1bf92ade6a17377a25. This change broke old frontends with new backends in case of remote debugging. We've check of allowable histogram classes in DevToolsUIBindings::RecordEnumeratedHistogram and unfortunately can't add new classes. Original CL: https://codereview.chromium.org/1520403004 > Devtools: Add metrics for drawer views being shown > Given that drawer views are taking an increasingly dominant UI position, > broad metric should be added like panels shown. > Committed: https://crrev.com/d4bebfb49bc2fad42b8b1a1bf92ade6a17377a25 > Cr-Commit-Position: refs/heads/master@{#367455} TBR=holte@chromium.org, pfeldman@chromium.org BUG=584795 Committed: https://crrev.com/631fffa06a4fd525318fbc87b27c27a8a7cdc912 Cr-Commit-Position: refs/heads/master@{#374020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -39 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Drawer.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js View 2 chunks +0 lines, -19 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +2 lines, -16 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672243003/1
4 years, 10 months ago (2016-02-06 00:43:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/19311)
4 years, 10 months ago (2016-02-06 02:27:16 UTC) #7
pfeldman
This did not stick. Is this an issue?
4 years, 10 months ago (2016-02-06 02:49:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672243003/1
4 years, 10 months ago (2016-02-06 03:34:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/19400)
4 years, 10 months ago (2016-02-06 04:04:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672243003/1
4 years, 10 months ago (2016-02-06 04:13:34 UTC) #14
kozy
On 2016/02/06 02:49:46, pfeldman wrote: > This did not stick. Is this an issue? I'd ...
4 years, 10 months ago (2016-02-06 04:29:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/19421)
4 years, 10 months ago (2016-02-06 04:49:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1672243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1672243003/1
4 years, 10 months ago (2016-02-06 07:30:03 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-06 08:36:58 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 08:38:04 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/631fffa06a4fd525318fbc87b27c27a8a7cdc912
Cr-Commit-Position: refs/heads/master@{#374020}

Powered by Google App Engine
This is Rietveld 408576698