Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1671873002: Fixed for-loop increments in InsertionPoint::setDistributedNodes. (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
Reviewers:
esprehn, hayato, kochi
CC:
chromium-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed for-loop increments in InsertionPoint::setDistributedNodes. When we reached the end of the old/new distributed nodes in the inner for-loop, we would do an extra increment of the index of the new/old distributed nodes which would then lead to skipping reattach for one of the elements. Also removed the special treatment of reattaching fallback elements as they would be part of the new/old vector and shouldn't need special treatment. The added test is currently not failing as it's hidden by a SubtreeStyleChange on the host element which I'll try to remove in a separate CL. R=hayato@chromium.org,kochi@chromium.org,esprehn@chromium.org BUG=584617 Committed: https://crrev.com/401f43989e320482084542f5f0153fcb7b4a8f98 Cr-Commit-Position: refs/heads/master@{#373805}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/content-reprojection-reattach.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/content-reprojection-reattach-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/InsertionPoint.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp View 3 chunks +4 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671873002/1
4 years, 10 months ago (2016-02-05 10:55:30 UTC) #2
rune
ptal
4 years, 10 months ago (2016-02-05 10:55:31 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-05 12:13:09 UTC) #5
hayato
lgtm
4 years, 10 months ago (2016-02-05 13:26:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671873002/1
4 years, 10 months ago (2016-02-05 13:48:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 13:52:48 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 13:53:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/401f43989e320482084542f5f0153fcb7b4a8f98
Cr-Commit-Position: refs/heads/master@{#373805}

Powered by Google App Engine
This is Rietveld 408576698