Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1677463002: Remove unnecessary recalc of host subtree on distribute. (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
Reviewers:
esprehn, hayato, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@distribute
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary recalc of host subtree on distribute. Nodes which need style recalculations after being distributed to new insertion points, new positions within insertion points, or simply not distributed anymore, are being reattached in InsertionPoint::setDistributionNodes(). R=hayato@chromium.org,kochi@chromium.org,esprehn@chromium.org TEST=fast/dom/shadow,fast/css BUG=584177 Committed: https://crrev.com/6969673edc422ff98080a1e6ff1fa798425954c6 Cr-Commit-Position: refs/heads/master@{#374629}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fixed test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/text/editing-text-crash-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/text-iterator-crash-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (6 generated)
rune
4 years, 10 months ago (2016-02-05 11:35:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677463002/1
4 years, 10 months ago (2016-02-05 13:56:34 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/169835)
4 years, 10 months ago (2016-02-05 15:10:00 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677463002/40001
4 years, 10 months ago (2016-02-08 12:04:29 UTC) #7
rune
Regarding the changed test-expectations: The dumped text now contains the characters you see output for ...
4 years, 10 months ago (2016-02-08 13:02:46 UTC) #8
rune
So, ptal.
4 years, 10 months ago (2016-02-08 13:03:09 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 15:40:21 UTC) #11
esprehn
lgtm seems legit.
4 years, 10 months ago (2016-02-10 01:20:58 UTC) #12
esprehn
lgtm
4 years, 10 months ago (2016-02-10 01:21:00 UTC) #13
kochi
lgtm
4 years, 10 months ago (2016-02-10 02:24:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677463002/40001
4 years, 10 months ago (2016-02-10 07:20:28 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-10 08:27:04 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 08:28:14 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6969673edc422ff98080a1e6ff1fa798425954c6
Cr-Commit-Position: refs/heads/master@{#374629}

Powered by Google App Engine
This is Rietveld 408576698