Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1544)

Issue 1671833002: Support 16-bit images in downsampler. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
ballbach
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support 16-bit images in downsampler. The downsampler was not sampling correctly from 16-bit images, resulting in using the RRG bytes (of the RRGGBB 16-bit pixel) for RGB in the 8-bit output. Original code review: https://codereview.chromium.org/1663983002/ Original author: ballbach@google.com BUG=583804 R=ballbach@google.com Committed: https://pdfium.googlesource.com/pdfium/+/b1dde8b188a20b5b7de53908bc434d2c82c22217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
4 years, 7 months ago (2016-02-05 09:05:17 UTC) #2
ballbach
lgtm - thank you
4 years, 7 months ago (2016-02-05 09:10:02 UTC) #3
Lei Zhang
4 years, 7 months ago (2016-02-05 09:23:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1dde8b188a20b5b7de53908bc434d2c82c22217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698