Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(315)

Issue 1663983002: Support 16-bit images in downsampler. (Closed)

Created:
4 years, 7 months ago by ballbach
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support 16-bit images in downsampler. The downsampler was not sampling correctly from 16-bit images, resulting in using the RRG bytes (of the RRGGBB 16-bit pixel) for RGB in the 8-bit output. BUG=583804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ballbach
I would love to add an example PDF (there's one in the bug) to the ...
4 years, 7 months ago (2016-02-03 22:38:38 UTC) #3
Lei Zhang
- Code looks good. - I edited the CL description to fix a typo and ...
4 years, 7 months ago (2016-02-03 23:13:56 UTC) #5
Lei Zhang
4 years, 7 months ago (2016-02-05 09:05:34 UTC) #6
Message was sent while issue was closed.
lgtm, but I closed this CL and will land it as
https://codereview.chromium.org/1671833002/ instead.

Powered by Google App Engine
This is Rietveld 408576698