[UI Views] Handle accelerators being pressed for buttons inside a menu

ui/views/controls/button/menu_button.cc

Index: ui/views/controls/button/menu_button.cc
diff --git a/ui/views/controls/button/menu_button.cc b/ui/views/controls/button/menu_button.cc
index 32cfd9c2a23818452c0c9cb98327352e39696b42..1c1e557b25d83758dc163b23d6d2e44d78f4acb9 100644
--- a/ui/views/controls/button/menu_button.cc
+++ b/ui/views/controls/button/menu_button.cc
@@ -278,6 +278,13 @@ void MenuButton::GetAccessibleState(ui::AXViewState* state) {
   state->AddStateFlag(ui::AX_STATE_HASPOPUP);
 }
 
+bool MenuButton::AcceleratorPressed(const ui::Accelerator& accelerator) {
+  // CustomButton::AcceleratorPressed ends up in NotifyClick, which doesn't work
+  // for menu buttons.
+  Activate();

[varkha, 2016/02/06 00:58:08]

why not "return Activate();"?

[Devlin, 2016/02/06 02:04:23]

The return value of Activate() is designed for mouse events, and is really odd
(e.g., it returns false if it processes the event and true if it doesn't). 
CustomButton::AcceleratorPressed() pretty much just eats the event as long as
it's reasonable, so I think we can take that approach.  But if we'd prefer to do
some more checking here, I'm open to it.

+  return true;
+}
+
 void MenuButton::PaintMenuMarker(gfx::Canvas* canvas) {
   gfx::Insets insets = GetInsets();