[UI Views] Handle accelerators being pressed for buttons inside a menu

ui/views/controls/button/menu_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/menu_button.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "ui/accessibility/ax_view_state.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 260 matching lines @@
   return false;
 }
 
 void MenuButton::GetAccessibleState(ui::AXViewState* state) {
   CustomButton::GetAccessibleState(state);
   state->role = ui::AX_ROLE_POP_UP_BUTTON;
   state->default_action = l10n_util::GetStringUTF16(IDS_APP_ACCACTION_PRESS);
   state->AddStateFlag(ui::AX_STATE_HASPOPUP);
 }
 
+bool MenuButton::AcceleratorPressed(const ui::Accelerator& accelerator) {
+  // CustomButton::AcceleratorPressed ends up in NotifyClick, which doesn't work
+  // for menu buttons.
+  Activate();

[varkha, 2016/02/06 00:58:08]

why not "return Activate();"?

[Devlin, 2016/02/06 02:04:23]

The return value of Activate() is designed for mouse events, and is really odd
(e.g., it returns false if it processes the event and true if it doesn't). 
CustomButton::AcceleratorPressed() pretty much just eats the event as long as
it's reasonable, so I think we can take that approach.  But if we'd prefer to do
some more checking here, I'm open to it.

+  return true;
+}
+
 void MenuButton::PaintMenuMarker(gfx::Canvas* canvas) {
   gfx::Insets insets = GetInsets();
 
   // Using the Views mirroring infrastructure incorrectly flips icon content.
   // Instead, manually mirror the position of the down arrow.
   gfx::Rect arrow_bounds(width() - insets.right() -
                          menu_marker_->width() - kMenuMarkerPaddingRight,
                          height() / 2 - menu_marker_->height() / 2,
                          menu_marker_->width(),
                          menu_marker_->height());
@@ skipping 73 matching lines @@
   if (!GetWidget()) {
     NOTREACHED();
     return 0;
   }
 
   gfx::Rect monitor_bounds = GetWidget()->GetWorkAreaBoundsInScreen();
   return monitor_bounds.right() - 1;
 }
 
 }  // namespace views