Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1671233002: Use the suid helper for oom_score_adj on Chrome OS. (Closed)

Created:
4 years, 10 months ago by rickyz (no longer on Chrome)
Modified:
4 years, 10 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the suid helper for oom_score_adj on Chrome OS. Reverts https://codereview.chromium.org/1560033003/ for Chrome OS. Chrome OS has a kernel patch which restricts the permissions of oom_score_adj. BUG=576409 Committed: https://crrev.com/64068c39982ad795f5041302500d85ce5fef54aa Cr-Commit-Position: refs/heads/master@{#373959}

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/browser/zygote_host/zygote_communication_linux.cc View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
rickyz (no longer on Chrome)
Created Revert of Do not use suid helper when using the namespace sandbox.
4 years, 10 months ago (2016-02-05 21:14:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671233002/1
4 years, 10 months ago (2016-02-05 21:16:02 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/127281) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 10 months ago (2016-02-05 21:19:40 UTC) #5
rickyz (no longer on Chrome)
I've un-TBRed this since the revert didn't apply cleanly, and scoped the revert to just ...
4 years, 10 months ago (2016-02-05 21:41:16 UTC) #7
mdempsky
lgtm
4 years, 10 months ago (2016-02-05 22:38:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671233002/40001
4 years, 10 months ago (2016-02-05 23:58:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-06 00:11:02 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 00:12:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64068c39982ad795f5041302500d85ce5fef54aa
Cr-Commit-Position: refs/heads/master@{#373959}

Powered by Google App Engine
This is Rietveld 408576698