Make SkPicture/SkImageGenerator default to SkCodec

Make SkPicture/SkImageGenerator default to SkCodec

Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.

Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.

Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.

Update all clients to use the default.

Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.

BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1671193002

Committed: https://skia.googlesource.com/skia/+/026388a01864c74208ad57d1ba4f711602d101c6

[scroggo, 2016-02-05 20:31:53]

Description was changed from

==========
Make SkPicture/SkImageGenerator default to SkCodec

Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.

Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.

Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.

Update all clients to use the default.

BUG=skia:4691
BUG=skia:4290
==========

to

==========
Make SkPicture/SkImageGenerator default to SkCodec

Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.

Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.

Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.

Update all clients to use the default.

BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-02-05 20:36:10]

scroggo@google.com changed reviewers:
+ msarett@google.com

[scroggo, 2016-02-05 20:36:11]

We may have to hold this up until we fix skbug.com/4888.

Otherwise, we won't be able to test YUV anymore.

[msarett, 2016-02-05 20:42:33]

Great!

Will this work when I land the YUV CL?  Last time I tried something like this, I
thought I ran into a bunch of ETC/ASTC/KTX problems.

[scroggo, 2016-02-05 21:18:30]

Description was changed from

==========
Make SkPicture/SkImageGenerator default to SkCodec

Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.

Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.

Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.

Update all clients to use the default.

BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make SkPicture/SkImageGenerator default to SkCodec

Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.

Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.

Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.

Update all clients to use the default.

Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.

BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[scroggo, 2016-02-05 21:19:24]

On 2016/02/05 20:42:33, msarett wrote:
> Great!
> 
> Will this work when I land the YUV CL?  Last time I tried something like this,
I
> thought I ran into a bunch of ETC/ASTC/KTX problems.

Now it will. I moved SkImageDecoderGenerator into KtxTest.cpp, so we can use it
directly.

[scroggo, 2016-02-09 13:22:09]

On 2016/02/05 21:19:24, scroggo wrote:
> On 2016/02/05 20:42:33, msarett wrote:
> > Great!
> > 
> > Will this work when I land the YUV CL?  Last time I tried something like
this,
> I
> > thought I ran into a bunch of ETC/ASTC/KTX problems.
> 
> Now it will. I moved SkImageDecoderGenerator into KtxTest.cpp, so we can use
it
> directly.

PTAL. All I've done is a rebase, but I'm still waiting on approval :)

[msarett, 2016-02-09 13:22:48]

lgtm

[scroggo, 2016-02-09 13:25:06]

scroggo@google.com changed reviewers:
+ reed@google.com

[scroggo, 2016-02-09 13:25:07]

Adding reed@ for API review on SkPicture.h

[reed1, 2016-02-09 15:29:53]

https://codereview.chromium.org/1671193002/diff/60001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1671193002/diff/60001/include/core/SkPicture....
include/core/SkPicture.h:62: static SkPicture* CreateFromStream(SkStream*,
InstallPixelRefProc proc = &DefaultInstall);
Do we need to expose DefaultInstall() directly? i.e. do clients ever need to
actually call it directly? Could we instead:

SkPicture* CreateFromStream(SkStream*);    // we handle installing our private
default
SkPicture* CreateFromStream(SkStream*, InstallPixelRefProc proc);   // they must
give us a proc

[scroggo, 2016-02-09 16:12:18]

https://codereview.chromium.org/1671193002/diff/60001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1671193002/diff/60001/include/core/SkPicture....
include/core/SkPicture.h:62: static SkPicture* CreateFromStream(SkStream*,
InstallPixelRefProc proc = &DefaultInstall);
On 2016/02/09 15:29:53, reed1 wrote:
> Do we need to expose DefaultInstall() directly? i.e. do clients ever need to
> actually call it directly? Could we instead:
> 
> SkPicture* CreateFromStream(SkStream*);    // we handle installing our private
> default
> SkPicture* CreateFromStream(SkStream*, InstallPixelRefProc proc);   // they
must
> give us a proc

Done.

https://codereview.chromium.org/1671193002/diff/80001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1671193002/diff/80001/include/core/SkPicture....
include/core/SkPicture.h:60: *  Recreate a picture that was serialized into a
stream.
Should I include a comment alluding to how we'll decode any encoded images?

[reed1, 2016-02-09 20:46:26]

lgtm

https://codereview.chromium.org/1671193002/diff/80001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1671193002/diff/80001/include/core/SkPicture....
include/core/SkPicture.h:60: *  Recreate a picture that was serialized into a
stream.
On 2016/02/09 16:12:17, scroggo wrote:
> Should I include a comment alluding to how we'll decode any encoded images?

Sure. Something like...?

Serialized images will be passed to SkImage::NewFromData() or its equivalent

[scroggo, 2016-02-09 21:07:14]

https://codereview.chromium.org/1671193002/diff/80001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.chromium.org/1671193002/diff/80001/include/core/SkPicture....
include/core/SkPicture.h:60: *  Recreate a picture that was serialized into a
stream.
On 2016/02/09 20:46:26, reed1 wrote:
> On 2016/02/09 16:12:17, scroggo wrote:
> > Should I include a comment alluding to how we'll decode any encoded images?
> 
> Sure. Something like...?
> 
> Serialized images will be passed to SkImage::NewFromData() or its equivalent

Done - used SkIMageGenerator::NewFromEncoded, which is what we use today (and is
used by SkImage::NewFromData).

[scroggo, 2016-02-09 21:07:17]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-02-09 21:07:18]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1671193002/#ps100001
(title: "Add comment regarding serialized images")

[commit-bot: I haz the power, 2016-02-09 21:07:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671193002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671193002/100001

[commit-bot: I haz the power, 2016-02-09 21:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 21:21:20]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[scroggo, 2016-02-10 18:49:44]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-02-10 18:49:45]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com,
reed@google.com
Link to the patchset: https://codereview.chromium.org/1671193002/#ps120001
(title: "Move ImageGenerator impl into ktx code to share with nanobench")

[commit-bot: I haz the power, 2016-02-10 18:49:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1671193002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1671193002/120001

[commit-bot: I haz the power, 2016-02-10 19:15:41]

Description was changed from

==========
Make SkPicture/SkImageGenerator default to SkCodec

Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.

Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.

Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.

Update all clients to use the default.

Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.

BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make SkPicture/SkImageGenerator default to SkCodec

Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.

Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.

Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.

Update all clients to use the default.

Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.

BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/026388a01864c74208ad57d1ba4f711602d101c6
==========

[commit-bot: I haz the power, 2016-02-10 19:15:42]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/026388a01864c74208ad57d1ba4f711602d101c6

[kjlubick, 2016-02-10 19:24:55]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1685963004/ by kjlubick@google.com.

The reason for reverting is: Breaks Ubuntu and Mac CMAKE.

[scroggo, 2016-02-10 20:23:04]

On 2016/02/10 19:24:55, kjlubick wrote:
> A revert of this CL (patchset #7 id:120001) has been created in
> https://codereview.chromium.org/1685963004/ by mailto:kjlubick@google.com.
> 
> The reason for reverting is: Breaks Ubuntu and Mac CMAKE.

Errors are:

https://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86...:

Undefined symbols for architecture x86_64:
  "SkCodecImageGenerator::NewFromEncodedCodec(SkData*)", referenced from:
      SkImageGenerator::NewFromEncodedImpl(SkData*) in
SkImageGenerator_skia.cpp.o

https://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x8...

FAILED: : && /usr/bin/c++   -O3 -DNDEBUG   CMakeFiles/example.dir/example.cpp.o 
-o example  -rdynamic libskia.so -lGLU -lGL
-Wl,-rpath,/home/default/storage/skia-repo/buildbot/skiabot-linux-compile-001/build/slave/workdir/build/skia/out/Build-Ubuntu-GCC-x86_64-Release-CMake
&& :
libskia.so: undefined reference to
`SkCodecImageGenerator::NewFromEncodedCodec(SkData*)'

[scroggo, 2016-02-10 20:28:36]

Description was changed from

==========
Make SkPicture/SkImageGenerator default to SkCodec

Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.

Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.

Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.

Update all clients to use the default.

Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.

BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/026388a01864c74208ad57d1ba4f711602d101c6
==========

to

==========
Make SkPicture/SkImageGenerator default to SkCodec

Remove reference to SkImageDecoder from SkPicture. Make the default
InstallPixelRefProc passed to CreateFromStream use
SkImageGenerator::NewFromEncoded instead.

Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator.
Remove the old version that used SkImageDecoder.

Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default
now behaves lazily.

Update all clients to use the default.

Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly.

BUG=skia:4691
BUG=skia:4290
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/026388a01864c74208ad57d1ba4f711602d101c6
==========

[scroggo, 2016-02-18 17:33:34]

Matt relanded this at https://codereview.chromium.org/1699183004