Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1699183004: Make SkPicture/SkImageGenerator default to SkCodec (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkPicture/SkImageGenerator default to SkCodec Remove reference to SkImageDecoder from SkPicture. Make the default InstallPixelRefProc passed to CreateFromStream use SkImageGenerator::NewFromEncoded instead. Make SkImageGenerator::NewFromEncoded create an SkCodecImageGenerator. Remove the old version that used SkImageDecoder. Remove all versions of lazy_decode_bitmap/LazyDecodeBitmap. The default now behaves lazily. Update all clients to use the default. Move SkImageDecoderGenerator into KtxTest.cpp, and use it directly. This is a rebased version of: https://codereview.chromium.org/1671193002/ TBR=reed@google.com BUG=skia:4691 BUG=skia:4290 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1699183004 Committed: https://skia.googlesource.com/skia/+/8715d47e247bf890ee78af0774ae7e8698146b67

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix rebase bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -209 lines) Patch
M bench/ETCBitmapBench.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 3 chunks +2 lines, -7 lines 0 comments Download
M gyp/codec.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M gyp/images.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/tools.gyp View 1 2 5 chunks +0 lines, -18 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +13 lines, -2 lines 0 comments Download
M public.bzl View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkPicture.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M src/images/SkImageDecoder_ktx.cpp View 2 chunks +99 lines, -0 lines 0 comments Download
M src/ports/SkImageGenerator_skia.cpp View 1 chunk +2 lines, -94 lines 0 comments Download
M tests/KtxTest.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M tests/PictureTest.cpp View 5 chunks +32 lines, -2 lines 0 comments Download
D tools/LazyDecodeBitmap.h View 1 chunk +0 lines, -24 lines 0 comments Download
D tools/LazyDecodeBitmap.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
M tools/dump_record.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M tools/gpuveto.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M tools/lua/lua_pictures.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M tools/pinspect.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
msarett
This is just a rebase of: https://codereview.chromium.org/1671193002/ Looks to be succeeding on CMake now!
4 years, 10 months ago (2016-02-17 16:56:25 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699183004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699183004/20001
4 years, 10 months ago (2016-02-17 16:56:49 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/6285)
4 years, 10 months ago (2016-02-17 16:59:27 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699183004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699183004/40001
4 years, 10 months ago (2016-02-17 17:03:26 UTC) #11
reed1
api lgtm
4 years, 10 months ago (2016-02-17 17:10:14 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 17:38:55 UTC) #15
scroggo
lgtm
4 years, 10 months ago (2016-02-17 17:45:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1699183004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1699183004/40001
4 years, 10 months ago (2016-02-17 18:01:34 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 18:02:36 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/8715d47e247bf890ee78af0774ae7e8698146b67

Powered by Google App Engine
This is Rietveld 408576698