Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1671143002: Hard-code width of permissions bubble view (Closed)

Created:
4 years, 10 months ago by Evan Stade
Modified:
4 years, 10 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hard-code width of permissions bubble view this is a bandaid because bubble views should default to using this preferred width (but I'm afraid to make the sweeping change until I've spent more time verifying it's ok across more bubbles). BUG=584581 Committed: https://crrev.com/0cf2614cfd8d4d55b0e9a7786eff8094bd3334d3 Cr-Commit-Position: refs/heads/master@{#373898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
4 years, 10 months ago (2016-02-05 19:13:25 UTC) #2
msw
Ha; called it! I wonder what http://www.thelongestdomainnameintheworldandthensomeandthensomemoreandmore.com/ looks like in this bubble? shrug; lgtm
4 years, 10 months ago (2016-02-05 19:19:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1671143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1671143002/1
4 years, 10 months ago (2016-02-05 19:23:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 20:30:06 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 20:31:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cf2614cfd8d4d55b0e9a7786eff8094bd3334d3
Cr-Commit-Position: refs/heads/master@{#373898}

Powered by Google App Engine
This is Rietveld 408576698