Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc

Issue 1671143002: Hard-code width of permissions bubble view (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
diff --git a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
index b5784f18f89e0546dd01de48105f068e5750cee4..451cda3d930734d2fd05c69c4991e11329a464c0 100644
--- a/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
+++ b/chrome/browser/ui/views/website_settings/permissions_bubble_view.cc
@@ -170,6 +170,7 @@ class PermissionsBubbleDelegateView : public views::BubbleDelegateView,
const gfx::FontList& GetTitleFontList() const override;
base::string16 GetWindowTitle() const override;
void OnWidgetDestroying(views::Widget* widget) override;
+ gfx::Size GetPreferredSize() const override;
void GetAccessibleState(ui::AXViewState* state) override;
// ButtonListener:
@@ -345,6 +346,12 @@ void PermissionsBubbleDelegateView::OnWidgetDestroying(views::Widget* widget) {
}
}
+gfx::Size PermissionsBubbleDelegateView::GetPreferredSize() const {
+ // TODO(estade): bubbles should default to this width.
+ const int kWidth = 320 - GetInsets().width();
+ return gfx::Size(kWidth, GetHeightForWidth(kWidth));
+}
+
void PermissionsBubbleDelegateView::GetAccessibleState(ui::AXViewState* state) {
views::BubbleDelegateView::GetAccessibleState(state);
state->role = ui::AX_ROLE_ALERT_DIALOG;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698