Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1670983003: [interpreter] Rename HandlerTable::depth field. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy, Yang
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-test-enable
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Rename HandlerTable::depth field. This makes the field in question more generic by renaming it from the previous "depth" to "data". Pure refactoring, no function change. R=rmcilroy@chromium.org,yangguo@chromium.org Committed: https://crrev.com/badaf79f30fe2f6809acd89b1e87919cdcd86dc8 Cr-Commit-Position: refs/heads/master@{#33779}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -43 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/frames.h View 3 chunks +9 lines, -8 lines 0 comments Download
M src/frames.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/handler-table-builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/objects.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M src/objects.cc View 1 4 chunks +5 lines, -6 lines 0 comments Download
M src/objects-inl.h View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-05 11:30:06 UTC) #1
Yang
On 2016/02/05 11:30:06, Michael Starzinger wrote: lgtm
4 years, 10 months ago (2016-02-05 11:32:06 UTC) #2
rmcilroy
lgtm
4 years, 10 months ago (2016-02-05 12:19:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670983003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670983003/20001
4 years, 10 months ago (2016-02-05 13:45:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-05 13:51:49 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 13:52:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/badaf79f30fe2f6809acd89b1e87919cdcd86dc8
Cr-Commit-Position: refs/heads/master@{#33779}

Powered by Google App Engine
This is Rietveld 408576698