Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: src/frames.h

Issue 1670983003: [interpreter] Rename HandlerTable::depth field. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_interpreter-test-enable
Patch Set: Rebased. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug.cc ('k') | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index 92fe2723ea1791b085d6172a85daac2de4736b64..48e5a3e1490ec826cbb4747ab2bd95b4f5ddb603 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -624,9 +624,12 @@ class JavaScriptFrame: public StandardFrame {
virtual void Summarize(List<FrameSummary>* frames);
// Lookup exception handler for current {pc}, returns -1 if none found. Also
- // returns the expected number of stack slots at the handler site.
+ // returns data associated with the handler site specific to the frame type:
+ // - JavaScriptFrame : Data is the stack depth at entry of the try-block.
+ // - OptimizedFrame : Data is the stack slot count of the entire frame.
+ // - InterpretedFrame: Data is the register index holding the context.
virtual int LookupExceptionHandlerInTable(
- int* stack_slots, HandlerTable::CatchPrediction* prediction);
+ int* data, HandlerTable::CatchPrediction* prediction);
// Architecture-specific register description.
static Register fp_register();
@@ -698,10 +701,9 @@ class OptimizedFrame : public JavaScriptFrame {
void Summarize(List<FrameSummary>* frames) override;
- // Lookup exception handler for current {pc}, returns -1 if none found. Also
- // returns the expected number of stack slots at the handler site.
+ // Lookup exception handler for current {pc}, returns -1 if none found.
int LookupExceptionHandlerInTable(
- int* stack_slots, HandlerTable::CatchPrediction* prediction) override;
+ int* data, HandlerTable::CatchPrediction* prediction) override;
DeoptimizationInputData* GetDeoptimizationData(int* deopt_index) const;
@@ -721,10 +723,9 @@ class InterpretedFrame : public JavaScriptFrame {
public:
Type type() const override { return INTERPRETED; }
- // Lookup exception handler for current {pc}, returns -1 if none found. Also
- // returns the expected number of stack slots at the handler site.
+ // Lookup exception handler for current {pc}, returns -1 if none found.
int LookupExceptionHandlerInTable(
- int* stack_slots, HandlerTable::CatchPrediction* prediction) override;
+ int* data, HandlerTable::CatchPrediction* prediction) override;
// Returns the current offset into the bytecode stream.
int GetBytecodeOffset() const;
« no previous file with comments | « src/debug/debug.cc ('k') | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698