Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

Issue 1670743002: Move V8 extra-calling utilities to V8ScriptRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
index b819554340270c837630315485a82509567a4179..7cad8c0ebcc8fdc6a4bc7fe0a288ecb33bec7b93 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
@@ -1087,30 +1087,6 @@ CORE_EXPORT void v8ConstructorAttributeGetter(v8::Local<v8::Name> propertyName,
typedef void (*InstallTemplateFunction)(v8::Local<v8::FunctionTemplate>, v8::Isolate*);
-// Utiltiies for calling functions added to the V8 extras binding object.
-
-inline v8::MaybeLocal<v8::Value> v8CallExtraHelper(ScriptState* scriptState, const char* name, size_t numArgs, v8::Local<v8::Value>* args)
-{
- v8::Isolate* isolate = scriptState->isolate();
- ExecutionContext* ec = scriptState->executionContext();
- v8::Local<v8::Value> undefined = v8::Undefined(isolate);
- v8::Local<v8::Value> functionValue = scriptState->getFromExtrasExports(name).v8Value();
- v8::Local<v8::Function> function = functionValue.As<v8::Function>();
- return V8ScriptRunner::callFunction(function, ec, undefined, numArgs, args, isolate);
-}
-
-template <size_t N>
-v8::MaybeLocal<v8::Value> v8CallExtra(ScriptState* scriptState, const char* name, v8::Local<v8::Value>(&args)[N])
-{
- return v8CallExtraHelper(scriptState, name, N, args);
-}
-
-template <size_t N>
-v8::Local<v8::Value> v8CallExtraOrCrash(ScriptState* scriptState, const char* name, v8::Local<v8::Value>(&args)[N])
-{
- return v8CallOrCrash(v8CallExtraHelper(scriptState, name, N, args));
-}
-
} // namespace blink
#endif // V8Binding_h

Powered by Google App Engine
This is Rietveld 408576698